Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove getters from pallet-membership #4840

Merged

Conversation

PolkadotDom
Copy link
Contributor

@PolkadotDom PolkadotDom commented Jun 19, 2024

As per #3326 , removes pallet::getter macro usage from pallet-membership. The syntax StorageItem::<T, I>::get() should be used instead. Also converts some syntax to turbo and reimplements the removed getters, following #223

cc @muraca

@PolkadotDom PolkadotDom requested a review from a team as a code owner June 19, 2024 20:12
@paritytech-review-bot paritytech-review-bot bot requested a review from a team June 22, 2024 18:48
@PolkadotDom PolkadotDom requested a review from ggwpez June 22, 2024 19:00
@paritytech-review-bot paritytech-review-bot bot requested a review from a team June 24, 2024 19:11
@PolkadotDom PolkadotDom requested a review from bkchr June 24, 2024 19:13
Copy link
Contributor

@kianenigma kianenigma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lokks good once all CI checks pass.

Copy link
Contributor

@seadanda seadanda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a couple of docs conventions

substrate/frame/membership/src/lib.rs Outdated Show resolved Hide resolved
substrate/frame/membership/src/lib.rs Outdated Show resolved Hide resolved
@seadanda seadanda added the T2-pallets This PR/Issue is related to a particular pallet. label Jun 28, 2024
PolkadotDom and others added 2 commits June 28, 2024 15:34
@kianenigma kianenigma enabled auto-merge July 1, 2024 12:00
@kianenigma kianenigma added this pull request to the merge queue Jul 1, 2024
Merged via the queue into paritytech:master with commit 333f4c7 Jul 1, 2024
155 of 158 checks passed
@PolkadotDom PolkadotDom deleted the dom/remove-getters-pallet-membership branch July 1, 2024 19:46
TomaszWaszczyk pushed a commit to TomaszWaszczyk/polkadot-sdk that referenced this pull request Jul 7, 2024
As per paritytech#3326 , removes pallet::getter macro usage from
pallet-membership. The syntax StorageItem::<T, I>::get() should be used
instead. Also converts some syntax to turbo and reimplements the removed
getters, following paritytech#223

cc @muraca

---------

Co-authored-by: Dónal Murray <[email protected]>
Co-authored-by: Kian Paimani <[email protected]>
TarekkMA pushed a commit to moonbeam-foundation/polkadot-sdk that referenced this pull request Aug 2, 2024
As per paritytech#3326 , removes pallet::getter macro usage from
pallet-membership. The syntax StorageItem::<T, I>::get() should be used
instead. Also converts some syntax to turbo and reimplements the removed
getters, following paritytech#223

cc @muraca

---------

Co-authored-by: Dónal Murray <[email protected]>
Co-authored-by: Kian Paimani <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
T2-pallets This PR/Issue is related to a particular pallet.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants