Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix av-distribution Jaeger spans mem leak #5321

Merged
merged 3 commits into from
Aug 12, 2024
Merged

fix av-distribution Jaeger spans mem leak #5321

merged 3 commits into from
Aug 12, 2024

Conversation

alindima
Copy link
Contributor

Fixes #5258

@alindima alindima added I2-bug The node fails to follow expected behavior. T8-polkadot This PR/Issue is related to/affects the Polkadot network. labels Aug 12, 2024
@alindima alindima mentioned this pull request Aug 12, 2024
Closed
@alindima alindima requested a review from sandreim August 12, 2024 12:01
@paritytech-cicd-pr
Copy link

The CI pipeline was cancelled due to failure one of the required jobs.
Job name: test-linux-stable 2/3
Logs: https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/6969940

sandreim
sandreim approved these changes Aug 12, 2024
View reviewed changes
Copy link
Contributor

@sandreim sandreim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @alindima , seems we had this leak for quite a while 🙈

alexggh
alexggh approved these changes Aug 12, 2024
View reviewed changes
Copy link
Contributor

@alexggh alexggh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you check if we don't make the same mistakes in all the other subsystem using jaeger spawns ?

@alindima
Copy link
Contributor Author

Could you check if we don't make the same mistakes in all the other subsystem using jaeger spawns ?

yep. I checked for that ✅

@alindima alindima added this pull request to the merge queue Aug 12, 2024
Merged via the queue into master with commit fc906d5 Aug 12, 2024
171 of 173 checks passed
@alindima alindima deleted the alindima/fix-av-distribution-mem-leak branch August 12, 2024 14:31
alindima added a commit that referenced this pull request Aug 13, 2024
@alindima
fix av-distribution Jaeger spans mem leak (#5321)
d2b5dc4 
Fixes #5258
@alindima alindima mentioned this pull request Aug 13, 2024
Merged
EgorPopelyaev pushed a commit that referenced this pull request Aug 13, 2024
@alindima
[stable2407] Backport #5321 (#5332)
4eb5f81 
Backports #5321 on the
stable release
ordian added a commit that referenced this pull request Aug 14, 2024
@ordian
Merge branch 'master' into ao-enact-candidate-weight
ef78697 
* master: (35 commits)
  Fix OurViewChange small race (#5356)
  Make ticket non-optional and add ensure_successful method to Consideration trait (#5359)
  [tests] dedup test code, add more tests, improve naming and docs (#5338)
  Stop running the wishlist workflow on forks (#5297)
  Migrate foreign assets v3::Location to v4::Location (#4129)
  Minor clean up (#5284)
  [Pools] Ensure members can always exit the pool gracefully (#4998)
  StorageWeightReclaim: set to node pov size if higher (#5281)
  [Bot] Add prdoc generation (#5331)
  Small nits found accidentally along the way (#5341)
  Create subsystem-benchmarks.yml (#5325)
  Bump libp2p-identity from 0.2.8 to 0.2.9 (#5232)
  Bump authoring duration for async backing to 2s. (#5195)
  Fix spelling issues (#5206)
  Bump the known_good_semver group across 1 directory with 3 updates (#5315)
  `polkadot-node-core-pvf-common`: Fix test compilation error (#5310)
  ci: Paused `cmd-action` commenter (#5287)
  Remove unnecessary mut (#5318)
  chain-spec: minor clarification on the genesis config patch (#5324)
  fix av-distribution Jaeger spans mem leak (#5321)
  ...
ordian added a commit that referenced this pull request Aug 14, 2024
@ordian
Merge branch 'master' into ao-fix-parainclusion-weight-overestimation
cbe0b3f 
* master: (35 commits)
  Fix OurViewChange small race (#5356)
  Make ticket non-optional and add ensure_successful method to Consideration trait (#5359)
  [tests] dedup test code, add more tests, improve naming and docs (#5338)
  Stop running the wishlist workflow on forks (#5297)
  Migrate foreign assets v3::Location to v4::Location (#4129)
  Minor clean up (#5284)
  [Pools] Ensure members can always exit the pool gracefully (#4998)
  StorageWeightReclaim: set to node pov size if higher (#5281)
  [Bot] Add prdoc generation (#5331)
  Small nits found accidentally along the way (#5341)
  Create subsystem-benchmarks.yml (#5325)
  Bump libp2p-identity from 0.2.8 to 0.2.9 (#5232)
  Bump authoring duration for async backing to 2s. (#5195)
  Fix spelling issues (#5206)
  Bump the known_good_semver group across 1 directory with 3 updates (#5315)
  `polkadot-node-core-pvf-common`: Fix test compilation error (#5310)
  ci: Paused `cmd-action` commenter (#5287)
  Remove unnecessary mut (#5318)
  chain-spec: minor clarification on the genesis config patch (#5324)
  fix av-distribution Jaeger spans mem leak (#5321)
  ...
@github-actions github-actions bot mentioned this pull request Oct 8, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sandreim sandreim sandreim approved these changes

@alexggh alexggh alexggh approved these changes

Assignees
No one assigned
Labels
I2-bug The node fails to follow expected behavior. T8-polkadot This PR/Issue is related to/affects the Polkadot network.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

availability-distribution: potential memory leak
4 participants
@alindima @paritytech-cicd-pr @alexggh @sandreim