Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Bot] Add prdoc generation #5331
[Bot] Add prdoc generation #5331
Changes from 2 commits
61af3bf
f21d0c6
3bbf728
cf34c55
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
may be you could also alternatively add an option to start it with command?
like here https://github.com/polkadot-fellows/runtimes/pull/406/files#diff-38149785bc1a430631c477eabc9b0970804d2c9433504a67574d0b9d38461ba6R120
Or I will do later for all
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have a
type
set on all inputs to eithernumber
orchoice
so i dont think that there can be any query injection.But i would also prefer comments, as outsiders can probably not run CI actions. Not sure why the comment approach was deprecated?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it wasn't deprecated, we just tried to move to GHA faster/cheaper, and that was one of the fast and secure ways