[To be merged in another PR]: small improvment on top of transaction extension PR #5440
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as outdated.
This comment was marked as outdated.
gui1117
force-pushed
the
gui-stage1-cleanup-maybe
branch
from
2949934
to
330f64b
Compare
gui1117
force-pushed
the
gui-stage1-cleanup-maybe
branch
from
330f64b
to
44b58a3
Compare
gui1117
changed the title
georgepisaltu
approved these changes
Sep 18, 2024
prdoc/pr_2280.prdoc
Outdated
| @@ -48,7 +48,7 @@ doc: | |||
| contextual data that is injected into the transaction extension logic. It is unused in | |||
| instances migrated from `SignedExtension`. | |||
| - Extensions now track the weight they consume during valdiation, preparation and | |||
| post-dispatch through the `TransactionExtensionBase::weight` function. | |||
There was a problem hiding this comment.
PR 2280 was merged already, then reverted. Maybe we should leave this as is for posterity?
| impl TransactionExtensionBase for Tuple { | ||
| for_tuples!( where #( Tuple: TransactionExtensionBase )* ); | ||
| impl<Call: Dispatchable> TransactionExtension<Call> for Tuple { | ||
| for_tuples!( where #( Tuple: TransactionExtension<Call> )* ); |
There was a problem hiding this comment.
Should be removed according to this comment right?
substrate/primitives/runtime/src/traits/transaction_extension/mod.rs
Outdated
Show resolved
Hide resolved
georgepisaltu
merged commit 56012d4
into
paritytech:george/restore-gav-tx-ext
160 of 205 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
additional_signedtoimplicit(doesn't break metadata, only temporary representation in the code)SignaturePayloadFrom<u64>from transaction payment transaction extensionTransactionExtensionBase, merged intoTransactionExtension