Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Command bot GHA v2 - /cmd <cmd> #5457

Merged
merged 8 commits into from
Aug 28, 2024
Merged

Command bot GHA v2 - /cmd <cmd> #5457

merged 8 commits into from
Aug 28, 2024

Conversation

mordamax
Copy link
Contributor

@mordamax mordamax commented Aug 24, 2024 •
edited
Loading

Closes https://github.com/paritytech/product-engineering/issues/93

  • Deprecates old command bot bash scripts. New cmd implementation is re-written on Python
  • Deprecates sync command, which was never used
  • Benchmarks:
    • Uses new frame-omni-bencher
    • Simplifies usage to only providing a runtime and/or pallet name (even multiple runtimes or pallets)
    • Supports sub-modules (like /cmd bench --runtime dev --pallet pallet_asset_conversion_ops)
    • Can regenerate all weights with one command (substrate, polkadot, cumulus) for provided pallet(s) name
    • Adds subweight diff as a result of bench command

mordamax and others added 3 commits August 21, 2024 09:55
@mordamax
cmd initial
f78c945
@mordamax
Merge branch 'master' into mak-new-cmd
85ddf4c
@mordamax
cmd.yml
c191277 
remove rust installation + add forklift
submodules + dev runtime
adjst subweight
update ui
fix regex
remove old commands
modify help
docs
@mordamax mordamax added the R0-silent Changes should not be mentioned in any release notes label Aug 24, 2024
@mordamax mordamax marked this pull request as ready for review August 24, 2024 10:11
@mordamax mordamax requested review from a team as code owners August 24, 2024 10:11
@paritytech-review-bot paritytech-review-bot bot requested a review from a team August 24, 2024 10:12
ggwpez
ggwpez reviewed Aug 26, 2024
View reviewed changes
.github/scripts/cmd/cmd.py Show resolved Hide resolved
.github/scripts/cmd/cmd.py Outdated Show resolved Hide resolved
.github/scripts/cmd/cmd.py Outdated Show resolved Hide resolved
.github/scripts/cmd/cmd.py Show resolved Hide resolved
.github/scripts/cmd/cmd.py Show resolved Hide resolved
.github/workflows/cmd.yml Outdated Show resolved Hide resolved
.github/workflows/cmd.yml Show resolved Hide resolved
.github/workflows/cmd.yml Show resolved Hide resolved
.github/workflows/cmd.yml Show resolved Hide resolved
docs/contributor/commands-readme.md Show resolved Hide resolved
kianenigma
kianenigma approved these changes Aug 26, 2024
View reviewed changes
Copy link
Contributor

@kianenigma kianenigma left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Didn't do a deep review of the py file but I am sure we can iterate, as long as the basic objective is done and other comments are addressed.

Speaking of that: Can we have regression tests, especially for bench?

bkchr
bkchr reviewed Aug 26, 2024
View reviewed changes
.github/workflows/cmd.yml Show resolved Hide resolved
.github/workflows/cmd.yml Show resolved Hide resolved
.github/workflows/cmd.yml Outdated Show resolved Hide resolved
@mordamax mordamax requested review from bkchr and ggwpez August 26, 2024 17:07
@mordamax
Copy link
Contributor Author

@ggwpez @bkchr pushed 676e0e0 as followup, could you please re-check?

alvicsam
alvicsam reviewed Aug 27, 2024
View reviewed changes
.github/workflows/cmd.yml Outdated Show resolved Hide resolved
alvicsam
alvicsam reviewed Aug 27, 2024
View reviewed changes
.github/workflows/cmd.yml Outdated Show resolved Hide resolved
alvicsam
alvicsam approved these changes Aug 27, 2024
View reviewed changes
Copy link
Contributor

@alvicsam alvicsam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but a few checkouts seems to be redundant

.github/workflows/cmd.yml Show resolved Hide resolved
.github/workflows/cmd.yml Show resolved Hide resolved
@mordamax mordamax added this pull request to the merge queue Aug 28, 2024
Merged via the queue into paritytech:master with commit 8e0cefc Aug 28, 2024
188 checks passed
@mordamax mordamax deleted the mak-new-cmd branch August 28, 2024 20:58
ordian added a commit that referenced this pull request Aug 29, 2024
@ordian
Merge branch 'master' into ao-enact-candidate-weight
629a541 
* master: (39 commits)
  short-term fix for para inherent weight overestimation (#5082)
  CI: Add backporting bot (#4795)
  Fix benchmark failures when using `insecure_zero_ed` flag (#5354)
  Command bot GHA v2 - /cmd <cmd> (#5457)
  Remove pallet::getter usage from treasury (#4962)
  Bump blake2b_simd from 1.0.1 to 1.0.2 (#5404)
  Bump rustversion from 1.0.14 to 1.0.17 (#5405)
  Bridge zombienet tests: remove old command (#5434)
  polkadot-parachain: Add omni-node variant with u64 block number (#5269)
  Refactor verbose test (#5506)
  Use umbrella crate for minimal template (#5155)
  IBP Coretime Polkadot bootnodes (#5499)
  rpc server: listen to `ipv6 socket` if available and `--experimental-rpc-endpoint` CLI option (#4792)
  Update approval-voting-regression-bench (#5504)
  change try-runtime rpc domains (#5443)
  polkadot-parachain-bin: Remove contracts parachain (#5471)
  Add feature to allow Aura collator to use full PoV size (#5393)
  Adding stkd bootnodes (#5470)
  Make `PendingConfigs` storage item public (#5467)
  frame-omni-bencher maintenance (#5466)
  ...
@ggwpez ggwpez mentioned this pull request Sep 9, 2024
Merged
@ggwpez
Copy link
Member

ggwpez commented Sep 9, 2024

I just realized now that this deleted my bot that was just added in #5331
?! Im going to bring that file back.

@mordamax
Copy link
Contributor Author

mordamax commented Sep 9, 2024 •
edited
Loading

I just realized now that this deleted my bot that was just added in #5331 ?! Im going to bring that file back.

oops, sorry @ggwpez , my bad. I can return this, but not in original file, but just add it to a new command bot, wdyt?

UPD: created an issue #5647

@ggwpez ggwpez mentioned this pull request Sep 9, 2024
Merged
@ggwpez
Copy link
Member

ggwpez commented Sep 9, 2024

oops, sorry @ggwpez , my bad. I can return this, but not in original file, but just add it to a new command bot, wdyt?

Yea possible, i brought it back now here: #5648 feel free to integrate it into the /cmd, but i think until then we can already start using it like this.

github-merge-queue bot pushed a commit that referenced this pull request Sep 9, 2024
@ggwpez
[Bot] Revive prdoc bot (#5648)
2d4e89f 
Prdoc bot was deleted in
#5457 just after being
added in #5331 without
replacement.
Now bringing it back until it is integrated into the new command
structure.

Formatting is now also fixed, such that the title is always first and
the description renders correctly.

---------

Signed-off-by: Oliver Tale-Yazdi <[email protected]>
@mordamax mordamax mentioned this pull request Sep 13, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alvicsam alvicsam alvicsam approved these changes

@ggwpez ggwpez ggwpez approved these changes

@AndWeHaveAPlan AndWeHaveAPlan AndWeHaveAPlan approved these changes

@EgorPopelyaev EgorPopelyaev EgorPopelyaev approved these changes

@kianenigma kianenigma kianenigma approved these changes

@bkchr bkchr Awaiting requested review from bkchr

Assignees
No one assigned
Labels
R0-silent Changes should not be mentioned in any release notes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@mordamax @ggwpez @kianenigma @bkchr @EgorPopelyaev @AndWeHaveAPlan @alvicsam