Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Backport] Always include UnpaidExecution, not just when revenue is nonzero #5510

Merged
merged 2 commits into from
Aug 28, 2024
Merged

[Backport] Always include UnpaidExecution, not just when revenue is nonzero #5510

merged 2 commits into from
Aug 28, 2024

Commits on Aug 28, 2024

  1. [Coretime] Always include UnpaidExecution, not just when revenue is >… 

    … 0 (#5369)

The NotifyRevenue XCM from relay to coretime chain fails to pass the
barrier when revenue is 0.


https://github.com/paritytech/polkadot-sdk/blob/master/polkadot/runtime/parachains/src/coretime/mod.rs#L401
pushes notifyrevenue onto an [empty
vec](https://github.com/paritytech/polkadot-sdk/blob/master/polkadot/runtime/parachains/src/coretime/mod.rs#L361)
when `revenue == 0`, so it never explicitly requests unpaid execution,
because that happens only in [the block where revenue is `>
0`](https://github.com/paritytech/polkadot-sdk/blob/master/polkadot/runtime/parachains/src/coretime/mod.rs#L387).

This will need to be backported to 1.14 when merged.
    @seadanda
    seadanda committed Aug 28, 2024
    Configuration menu
    Copy the full SHA
    f570b0d View commit details
    Browse the repository at this point in the history

  2. Rename prdoc

    @seadanda
    seadanda committed Aug 28, 2024
    Configuration menu
    Copy the full SHA
    759bc34 View commit details
    Browse the repository at this point in the history