Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace lazy_static with LazyLock #5716

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Replace lazy_static with LazyLock #5716

wants to merge 5 commits into from

Conversation

programskillforverification
Copy link
Contributor

Description

close #5641

@programskillforverification programskillforverification marked this pull request as ready for review September 17, 2024 17:52
bkchr
bkchr approved these changes Sep 17, 2024
View reviewed changes
Copy link
Member

@bkchr bkchr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ty!

I think we can remove the one and only OnceLock and replace this with a LazyLock as well :D

polkadot/node/network/dispute-distribution/src/tests/mock.rs Outdated Show resolved Hide resolved
@programskillforverification programskillforverification changed the title Replace lazy_static with OnceLock Replace lazy_static with LazyLock Sep 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bkchr bkchr bkchr approved these changes

@koute koute Awaiting requested review from koute koute is a code owner

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Replace lazy_static with OnceLock
2 participants
@programskillforverification @bkchr