[pallet-revive] rework balance transfers #6187

xermicus · 2024-10-23T08:42:39Z

This PR removes the transfer syscall and changes balance transfers to make the existential deposit (ED) fully transparent for contracts.

The transfer API is removed since there is no corresponding EVM opcode and transferring via a call introduces barely any overhead.

We make the ED transparent to contracts by transferring the ED from the call origin to nonexistent accounts. Without this change, transfers to nonexistant accounts will transfer the supplied value minus the ED from the contracts viewpoint, and consequentially fail if the supplied value lies below the ED. Changing this behavior removes the need for contract code to handle this rather annoying corner case and aligns better with the EVM. The EVM charges a similar deposit from the gas meter, so transferring the ED from the call origin is practically the same as the call origin pays for gas.

Signed-off-by: xermicus <[email protected]>

xermicus · 2024-10-23T08:42:53Z

bot fmt

command-bot · 2024-10-23T08:42:59Z

@xermicus https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/7623826 was started for your command "$PIPELINE_SCRIPTS_DIR/commands/fmt/fmt.sh". Check out https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/pipelines?page=1&scope=all&username=group_605_bot to know what else is being executed currently.

Comment bot cancel 28-6d18c65e-886a-4ddc-a6e9-59d50defd791 to cancel this command or bot cancel to cancel all commands in this pull request.

command-bot · 2024-10-23T08:43:42Z

@xermicus Command "$PIPELINE_SCRIPTS_DIR/commands/fmt/fmt.sh" has finished. Result: https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/7623826 has finished. If any artifacts were generated, you can download them from https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/7623826/artifacts/download.

xermicus · 2024-10-23T08:45:35Z

/cmd prdoc --audience runtime_dev --bump major

…bump major'

Signed-off-by: xermicus <[email protected]>

substrate/frame/revive/src/exec.rs

substrate/frame/revive/fixtures/contracts/drain.rs

Co-authored-by: PG Herveou <[email protected]>

xermicus · 2024-10-26T17:09:39Z

bot bench substrate-pallet --pallet=pallet_revive

command-bot · 2024-10-26T17:09:44Z

@xermicus https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/7649092 was started for your command "$PIPELINE_SCRIPTS_DIR/commands/bench/bench.sh" --subcommand=pallet --runtime=dev --target_dir=substrate --features=riscv --pallet=pallet_revive. Check out https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/pipelines?page=1&scope=all&username=group_605_bot to know what else is being executed currently.

Comment bot cancel 37-9df3f922-8509-4c02-a382-37e5971d1058 to cancel this command or bot cancel to cancel all commands in this pull request.

command-bot · 2024-10-26T17:12:06Z

@xermicus Command "$PIPELINE_SCRIPTS_DIR/commands/bench/bench.sh" --subcommand=pallet --runtime=dev --target_dir=substrate --features=riscv --pallet=pallet_revive has finished. Result: https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/7649092 has finished. If any artifacts were generated, you can download them from https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/7649092/artifacts/download.

athei · 2024-10-30T10:24:51Z

Will review when conflicts are resolved.

xermicus · 2024-11-04T08:27:01Z

bot fmt

command-bot · 2024-11-04T08:27:06Z

@xermicus https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/7683739 was started for your command "$PIPELINE_SCRIPTS_DIR/commands/fmt/fmt.sh". Check out https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/pipelines?page=1&scope=all&username=group_605_bot to know what else is being executed currently.

Comment bot cancel 13-5397d7a8-da58-49de-8704-b33bb250da91 to cancel this command or bot cancel to cancel all commands in this pull request.

command-bot · 2024-11-04T08:30:36Z

@xermicus Command "$PIPELINE_SCRIPTS_DIR/commands/fmt/fmt.sh" has finished. Result: https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/7683739 has finished. If any artifacts were generated, you can download them from https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/7683739/artifacts/download.

Signed-off-by: Cyrill Leutwiler <[email protected]>

xermicus · 2024-11-04T11:02:16Z

bot fmt

command-bot · 2024-11-04T11:02:21Z

@xermicus https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/7685784 was started for your command "$PIPELINE_SCRIPTS_DIR/commands/fmt/fmt.sh". Check out https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/pipelines?page=1&scope=all&username=group_605_bot to know what else is being executed currently.

Comment bot cancel 14-be5cf3a1-9bf2-4d53-a4e9-21b46497c684 to cancel this command or bot cancel to cancel all commands in this pull request.

command-bot · 2024-11-04T11:06:05Z

@xermicus Command "$PIPELINE_SCRIPTS_DIR/commands/fmt/fmt.sh" has finished. Result: https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/7685784 has finished. If any artifacts were generated, you can download them from https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/7685784/artifacts/download.

substrate/frame/revive/src/exec.rs

* master: (129 commits) pallet-revive: Use `RUSTUP_TOOLCHAIN` if set (#6365) [eth-rpc] proxy /health (#6360) [Release|CI/CD] adjust release pipelines (#6366) Bump the known_good_semver group across 1 directory with 3 updates (#6339) Run check semver in MQ (#6287) [Deprecation] deprecate treasury `spend_local` call and related items (#6169) refactor and harden check_core_index (#6217) litep2p: Update litep2p to v0.8.0 (#6353) [pallet-staking] Additional check for virtual stakers (#5985) migrate pallet-remarks to v2 bench syntax (#6291) Remove leftover references of Wococo (#6361) snowbridge: allow account conversion for Ethereum accounts (#6221) authority-discovery: Populate DHT records with public listen addresses (#6298) Bounty Pallet: add `approve_bounty_with_curator` call to `bounties` pallet (#5961) Silent annoying log (#6351) [pallet-revive] rework balance transfers (#6187) `statement-distribution`: RFC103 implementation (#5883) Disable flaky tests reported in #6343 / #6345 (#6346) migrate pallet-recovery to benchmark V2 syntax (#6299) inclusion emulator: correctly handle UMP signals (#6178) ...

xermicus added 7 commits October 22, 2024 13:32

send ed from origin in transfers to inexistant accounts

67d662e

Signed-off-by: xermicus <[email protected]>

no deposit

d3422fe

Signed-off-by: xermicus <[email protected]>

remove old transfer api

2c570e0

Signed-off-by: xermicus <[email protected]>

fmt

4548da3

Signed-off-by: xermicus <[email protected]>

Merge branch 'master' into cl/callvalue-below-ed

dfe1b68

improve comment

4ca3a2d

Signed-off-by: xermicus <[email protected]>

add dedicated test

b9c39d1

Signed-off-by: xermicus <[email protected]>

xermicus added R0-silent Changes should not be mentioned in any release notes T7-smart_contracts This PR/Issue is related to smart contracts. labels Oct 23, 2024

xermicus requested review from pgherveou and athei October 23, 2024 08:42

".git/.scripts/commands/fmt/fmt.sh"

fa208d4

actions-user and others added 4 commits October 23, 2024 08:47

Update from xermicus running command 'prdoc --audience runtime_dev --…

6eeb0e9

…bump major'

improve test coverage

140ecbe

Signed-off-by: xermicus <[email protected]>

prdoc

90aab2e

Signed-off-by: xermicus <[email protected]>

prdoc

bab5973

Signed-off-by: xermicus <[email protected]>

pgherveou approved these changes Oct 24, 2024

View reviewed changes

substrate/frame/revive/src/exec.rs Outdated Show resolved Hide resolved

substrate/frame/revive/src/exec.rs Outdated Show resolved Hide resolved

substrate/frame/revive/src/exec.rs Show resolved Hide resolved

substrate/frame/revive/fixtures/contracts/drain.rs Show resolved Hide resolved

xermicus and others added 2 commits October 24, 2024 16:32

Update substrate/frame/revive/src/exec.rs

1d5ab1f

Co-authored-by: PG Herveou <[email protected]>

Merge branch 'master' into cl/callvalue-below-ed

e373ee5

Merge branch 'master' into cl/callvalue-below-ed

d36e993

".git/.scripts/commands/fmt/fmt.sh"

6acf08e

xermicus and others added 3 commits November 4, 2024 09:33

Merge branch 'master' into cl/callvalue-below-ed

2071241

fix

a5a37d1

Signed-off-by: Cyrill Leutwiler <[email protected]>

Merge branch 'master' into cl/callvalue-below-ed

2a0e887

".git/.scripts/commands/fmt/fmt.sh"

d456c94

pgherveou added 2 commits November 4, 2024 14:12

Merge branch 'master' into cl/callvalue-below-ed

2b11160

Use Preserve instead of Expandable to return balance

df525e4

pgherveou enabled auto-merge November 4, 2024 13:49

add missing use

28019bd

athei reviewed Nov 4, 2024

View reviewed changes

substrate/frame/revive/src/exec.rs Outdated Show resolved Hide resolved

PR review nit

91769fc

athei approved these changes Nov 4, 2024

View reviewed changes

pgherveou added this pull request to the merge queue Nov 4, 2024

Merged via the queue into master with commit d69a80e Nov 4, 2024
198 of 199 checks passed

pgherveou deleted the cl/callvalue-below-ed branch November 4, 2024 16:28

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[pallet-revive] rework balance transfers #6187

[pallet-revive] rework balance transfers #6187

xermicus commented Oct 23, 2024 •

edited

Loading

xermicus commented Oct 23, 2024

command-bot bot commented Oct 23, 2024 •

edited

Loading

command-bot bot commented Oct 23, 2024

xermicus commented Oct 23, 2024

xermicus commented Oct 26, 2024

command-bot bot commented Oct 26, 2024 •

edited

Loading

command-bot bot commented Oct 26, 2024

athei commented Oct 30, 2024

xermicus commented Nov 4, 2024

command-bot bot commented Nov 4, 2024 •

edited

Loading

command-bot bot commented Nov 4, 2024

xermicus commented Nov 4, 2024

command-bot bot commented Nov 4, 2024 •

edited

Loading

command-bot bot commented Nov 4, 2024

[pallet-revive] rework balance transfers #6187

[pallet-revive] rework balance transfers #6187

Conversation

xermicus commented Oct 23, 2024 • edited Loading

xermicus commented Oct 23, 2024

command-bot bot commented Oct 23, 2024 • edited Loading

command-bot bot commented Oct 23, 2024

xermicus commented Oct 23, 2024

xermicus commented Oct 26, 2024

command-bot bot commented Oct 26, 2024 • edited Loading

command-bot bot commented Oct 26, 2024

athei commented Oct 30, 2024

xermicus commented Nov 4, 2024

command-bot bot commented Nov 4, 2024 • edited Loading

command-bot bot commented Nov 4, 2024

xermicus commented Nov 4, 2024

command-bot bot commented Nov 4, 2024 • edited Loading

command-bot bot commented Nov 4, 2024

xermicus commented Oct 23, 2024 •

edited

Loading

command-bot bot commented Oct 23, 2024 •

edited

Loading

command-bot bot commented Oct 26, 2024 •

edited

Loading

command-bot bot commented Nov 4, 2024 •

edited

Loading

command-bot bot commented Nov 4, 2024 •

edited

Loading