Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

Improve misbehavior reports in CandidateBackingSubsystem #1387

Closed
montekki opened this issue Jul 9, 2020 · 2 comments · Fixed by #2222
Closed

Improve misbehavior reports in CandidateBackingSubsystem #1387

montekki opened this issue Jul 9, 2020 · 2 comments · Fixed by #2222
Assignees
@coriolinus
Labels
I8-refactor Code needs refactoring. S1-implement PR/Issue is in the implementation stage
Milestone
Medical Center

Comments

@montekki
Copy link
Contributor

montekki commented Jul 9, 2020

as noted in #1312 (comment) we have to be able to slash for a set of offences rather than for a single offence. To do that we likely need to

  • Unify the types used in subsystems and in statement-table.
  • Improve statement-table so it would report a set of offences for an AuthorityId.
@montekki montekki added the S1-implement PR/Issue is in the implementation stage label Jul 9, 2020
@rphmeier rphmeier added this to the Twinbrook milestone Jul 9, 2020
@rphmeier
Copy link
Contributor

rphmeier commented Jul 9, 2020

statement-table can drain_misbehavior, giving proofs of all misbehavior observed within that table. It should not be overcomplicated to transform those into many different reports. The only property we need is that there is a 1:1 mapping of reports issued by the statement table to reports issued to the relay chain.

@rphmeier
Copy link
Contributor

rphmeier commented Jul 9, 2020

Have just seen this comment and realize that I misremembered the API of the statement table.

@rphmeier rphmeier added the I8-refactor Code needs refactoring. label Jul 9, 2020
@rphmeier rphmeier modified the milestones: Twinbrook, Grosvenor Jul 20, 2020
@rphmeier rphmeier modified the milestones: Grosvenor, Medical Center Aug 20, 2020
@coriolinus coriolinus self-assigned this Jan 7, 2021
@coriolinus coriolinus mentioned this issue Jan 7, 2021
Merged
pepyakin added a commit that referenced this issue May 4, 2022
@pepyakin
Squashed 'bridges/' changes from f220d2fccab..d2faa6b2600
c0c1eee 
d2faa6b2600 Update spec_version for Rococo (#1387)
b3d701124fe Remove support for encoded-call messaging from relay and runtime integration code (#1376)
7f1c4af6650 fix copypaste (#1386)
4e195205ae2 re-enable BEEFY alarms for Rialto (#1385)
072ae865d6b fix for "`/root` is not writable." during deployments startup (#1384)
3ab1810b071 fix daily gitlab build (#1383)
3317b8a6811 Update Substrate/Polkadot refs for latest BEEFY + xcm-v3 capability (#1381)
ebfa9f2fef8 remove vault from ci (#1382)
82136eb42e3 Switch to gav-xcm-v3 branch to be able to test bridges + XCMv3 integration (#1378)
aa8896475b6 Revert "mention encoded-calls-messaging tag"
80c0f7ee05d mention encoded-calls-messaging tag
c7c6f0ce5e8 Revert "add api data() for inbound_lane (#1373)" (#1375)
6ef6bcc0169 FinalityEngine in substrate relay (#1374)
82698e3e082 add api data() for inbound_lane (#1373)
74a48878f86 pub use WeightInfo in Grandpa + Messsages pallets (#1370)
2cc27b7abb5 Update Substrate/Polkadot/Cumulus references (#1364)
9f3ffcd59c7 [ci] Use bridges-ci:production image in the pipeline (#1365)
61766e31f2e Few typos and clippy fixes (#1362)
REVERT: f220d2fccab Polkadot staging update (#1356)
REVERT: 92ddc3ea7a8 Polkadot-staging update (#1305)
REVERT: 29eecdf1fa1 Merge pull request #1294 from paritytech/polkadot-staging-update
REVERT: 173d2d82297 Merge pull request #1280 from paritytech/polkadot-staging-update
REVERT: 54146416e7f Merge pull request #1276 from paritytech/polkadot-staging-update
REVERT: df701181745 Merge branch 'master' into polkadot-staging-update
REVERT: f704a741ee8 Polkadot staging update (#1270)
REVERT: 1602249f0a2 Enable Beefy debug logs in test deployment (#1237)
REVERT: c61d240b474 Fix storage parameter name computation (#1238)
REVERT: 96d3808e88f Integrate BEEFY with Rialto & Millau runtimes (#1227)
REVERT: f75a1bdd9ba update dependencies (#1229)
REVERT: 957da038547 Add mut support (#1232)
REVERT: 8062637289f fixed set_operational in GRANDPA pallet (#1226)
REVERT: 14b36ca4eef Add CODEOWNERS file (#1219)
REVERT: 3bec15766f6 Unify metric names (#1209)
REVERT: 0e839d2423e remove abandoned exchange relay (#1217)
REVERT: 2c91c6815cf Remove unused `relays/headers` (#1216)
REVERT: 80b1e65db82 Remove unused PoA<>Substrate bridge (#1210)
REVERT: f36f76fc2a7 Fix UI deployment. (#1211)
REVERT: fc0b65365bb Add `AtLeast32BitUnsigned` for MessageLance::SourceChainBalance (#1207)

git-subtree-dir: bridges
git-subtree-split: d2faa6b2600fea77d121f3c0767cf59211e597a3
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@coriolinus coriolinus

Labels
I8-refactor Code needs refactoring. S1-implement PR/Issue is in the implementation stage
Projects
None yet
Milestone
Medical Center
Development

Successfully merging a pull request may close this issue.

misbehavior: report multiple offenses per validator as necessary paritytech/polkadot
3 participants
@montekki @coriolinus @rphmeier