This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
[CI] Build wasm blob with srtool and include prop hashes and blobs in release notes #1506
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
s3krit
added
A2-insubstantial
General-Beck
approved these changes
Jul 31, 2020
gabreal
reviewed
Aug 19, 2020
| matrix: | ||
| runtime: ['polkadot', 'kusama'] | ||
| container: | ||
| image: chevdor/srtool:nightly-2020-07-20 |
There was a problem hiding this comment.
afaiu according to our Docker images maintenance policy only official images or images based on them should be used.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, building the WASM blobs was done on the cleanroom server, manually initiated by me. Since we have reproducible builds of the WASM blobs using
srtoolnow, this isn't necessary.This PR includes the building of those blobs in Github Actions - using the Github-provided runners, this only takes 30 minutes for a clean build (around 10 minutes after that depending on caching, which is implemented) - which is faster than the Gitlab pipeline takes from start to finish, so this doesn't actually delay anything.
One important change is that now, the creation of the draft-release on tagging will only happen after the WASM blobs are built - which means there will be that 10-35 minute gap between pushing a tag and the draft release being created (and the #polkadot matrix channel being notified).
An example of the format of the release can be found here:
https://github.com/s3krit/polkadot/releases/tag/v0.8.19