Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

Network bridge refactoring impl #1537

Merged
30 commits merged into from
Aug 12, 2020
Merged

Network bridge refactoring impl #1537

30 commits merged into from
Aug 12, 2020

Conversation

rphmeier
Copy link
Contributor

@rphmeier rphmeier commented Aug 4, 2020

Based on guide updates from #1535

@rphmeier rphmeier added A3-in_progress Pull request is in progress. No review needed at this stage. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. labels Aug 4, 2020
@rphmeier rphmeier mentioned this pull request Aug 7, 2020
Merged
coriolinus
coriolinus approved these changes Aug 7, 2020
View reviewed changes
Copy link
Contributor

@coriolinus coriolinus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks plausible to me. I don't feel like I know enough yet to judge whether the semantics are correct, but the code looks good, modulo some nits.

node/subsystem/src/messages.rs Show resolved Hide resolved
node/network/protocol/src/lib.rs Outdated Show resolved Hide resolved
node/network/protocol/src/lib.rs Outdated Show resolved Hide resolved
node/network/bridge/src/lib.rs Show resolved Hide resolved
node/network/bridge/src/lib.rs Outdated Show resolved Hide resolved
node/network/bridge/src/lib.rs Outdated Show resolved Hide resolved
node/network/bridge/src/lib.rs Show resolved Hide resolved
node/network/bridge/src/lib.rs Show resolved Hide resolved
@rphmeier rphmeier marked this pull request as ready for review August 7, 2020 17:53
@rphmeier rphmeier added A0-please_review Pull request needs code review. and removed A3-in_progress Pull request is in progress. No review needed at this stage. labels Aug 7, 2020
@rphmeier
Copy link
Contributor Author

bot merge

@ghost
Copy link

ghost commented Aug 12, 2020

Waiting for commit status.

@ghost ghost merged commit 1e9c054 into master Aug 12, 2020
@ghost ghost deleted the rh-nb-refactor-impl branch August 12, 2020 11:16
ordian added a commit that referenced this pull request Aug 12, 2020
@ordian
Merge branch 'master' into ao-prometheus-metrics
fecef87 
* master:
  Network bridge refactoring impl (#1537)
  Augment Implementer's Guide XCMP docs (#1569)
  Support `build-spec` for other chains than Polkadot (#1567)
@rphmeier rphmeier mentioned this pull request Aug 18, 2020
Closed
This pull request was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@coriolinus coriolinus coriolinus approved these changes

Assignees
No one assigned
Labels
A0-please_review Pull request needs code review. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rphmeier @coriolinus