Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

A real overseer feature #1892

Merged
3 commits merged into from
Oct 31, 2020
Merged

A real overseer feature #1892

3 commits merged into from
Oct 31, 2020

Conversation

montekki
Copy link
Contributor

To test:

cargo run --release --features="real-overseer"  -- --tmp --chain rococo-local --validator --alice --force-authoring

@montekki montekki added A0-please_review Pull request needs code review. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. labels Oct 30, 2020
bkchr
bkchr approved these changes Oct 31, 2020
View reviewed changes
node/service/src/lib.rs Outdated Show resolved Hide resolved
@rphmeier @bkchr
Update node/service/src/lib.rs
cba0777 
Co-authored-by: Bastian Köcher <[email protected]>
@rphmeier
Copy link
Contributor

bot merge

@ghost
Copy link

ghost commented Oct 31, 2020

Waiting for commit status.

@ghost ghost merged commit 20a8a61 into paritytech:master Oct 31, 2020
@montekki montekki deleted the fs-real-overseer-feature branch October 31, 2020 10:51
@rphmeier rphmeier mentioned this pull request Oct 31, 2020
Merged
ordian added a commit that referenced this pull request Nov 2, 2020
@ordian
Merge branch 'master' into ao-more-resilient-subsystems-av-store
206713f 
* master:
  Adder collator improvements (#1896)
  Fixes bug that collator wasn't sending `Declare` message (#1895)
  fix service build: enable notifications protocol only under real overseer (#1894)
  Adds test parachain adder collator  (#1864)
  A real overseer feature (#1892)
  Implementer's guide: Approval Voting Subsystem (#1691)
  Companion for #6912 (#1784)
@joelamouche
Copy link

Hi, so I'm trying to learn more about Overseer and why I need to pass --features=real-overseer when testing my parachain (moonbeam).
What happens if I don't pass it?
Thanks in advance

@rphmeier
Copy link
Contributor

rphmeier commented Jan 5, 2021

If you don't pass --features=real-overseer then all parachains consensus components are replaced with dummy versions that don't do anything.

@joelamouche
Copy link

So block won't be produced on the parachains?

This pull request was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bkchr bkchr bkchr approved these changes

@ordian ordian ordian approved these changes

@coriolinus coriolinus Awaiting requested review from coriolinus

@rphmeier rphmeier Awaiting requested review from rphmeier

Assignees
No one assigned
Labels
A0-please_review Pull request needs code review. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@montekki @rphmeier @joelamouche @ordian @bkchr