Add support for wasm runtime metrics try #2 #4483

sandreim · 2021-12-07T16:42:30Z

Fixes #4383

Companion for paritytech/substrate#10440

skip check-dependent-cumulus

Signed-off-by: Andrei Sandu <[email protected]>

drahnr

I like the approach with a second order function 👍

Signed-off-by: Andrei Sandu <[email protected]>

node/metrics/src/runtime.rs

cli/src/cli.rs

…/runtime_metrics_try2

Signed-off-by: Andrei Sandu <[email protected]>

drahnr

LGTM, a few small nits, but looks good overall. Encapsulating the metrics boilerplate is going to be addressed in a follow up PR.

node/metrics/src/runtime.rs

drahnr · 2021-12-15T12:37:26Z

node/metrics/src/runtime.rs

+	where
+		F: FnOnce(MutexGuard<'_, HashMap<String, Counter<U64>>>) -> Result<(), PrometheusError>,
+	{
+		let _ = self.1.counters.lock().map(do_something).or_else(|error| {


nit: map_err is a mild improvement

node/metrics/src/tests.rs

runtime/parachains/src/paras_inherent/mod.rs

scripts/gitlab/test_linux_stable.sh

Signed-off-by: Andrei Sandu <[email protected]>

runtime/parachains/src/paras_inherent/mod.rs

Signed-off-by: Andrei Sandu <[email protected]>

scripts/gitlab/test_linux_stable.sh

Signed-off-by: Andrei Sandu <[email protected]>

runtime/metrics/src/std.rs

runtime/metrics/src/lib.rs

Signed-off-by: Andrei Sandu <[email protected]>

bkchr

One last nitpick

primitives/src/v1/metrics.rs

Signed-off-by: Andrei Sandu <[email protected]>

…trics_try2

paritytech-processbot · 2021-12-16T11:22:37Z

Waiting for commit status.

* Add runtime metrics provider Signed-off-by: Andrei Sandu <[email protected]> * Runner changes Signed-off-by: Andrei Sandu <[email protected]> * Some sample metrics in paras_inherent Signed-off-by: Andrei Sandu <[email protected]> * update cargo toml Signed-off-by: Andrei Sandu <[email protected]> * fmt Signed-off-by: Andrei Sandu <[email protected]> * bug Signed-off-by: Andrei Sandu <[email protected]> * more fmt after merge Signed-off-by: Andrei Sandu <[email protected]> * Refactor metric prefix override Signed-off-by: Andrei Sandu <[email protected]> * fmt Signed-off-by: Andrei Sandu <[email protected]> * remove bug comment Signed-off-by: Andrei Sandu <[email protected]> * Add runtime metric primitives Signed-off-by: Andrei Sandu <[email protected]> * Impl trace event parsing Signed-off-by: Andrei Sandu <[email protected]> * Update metrics Signed-off-by: Andrei Sandu <[email protected]> * cargo lock Signed-off-by: Andrei Sandu <[email protected]> * fmt Signed-off-by: Andrei Sandu <[email protected]> * Fix target check Signed-off-by: Andrei Sandu <[email protected]> * Runtime metrics primitives Signed-off-by: Andrei Sandu <[email protected]> * Review feedback Signed-off-by: Andrei Sandu <[email protected]> * Runtime metrics crate Signed-off-by: Andrei Sandu <[email protected]> * Node side runtime metric changes Signed-off-by: Andrei Sandu <[email protected]> * use runtime CounterVec instead of macro Signed-off-by: Andrei Sandu <[email protected]> * fmt nice Signed-off-by: Andrei Sandu <[email protected]> * remove dead code Signed-off-by: Andrei Sandu <[email protected]> * base58 decoding Signed-off-by: Andrei Sandu <[email protected]> * base58 encoding Signed-off-by: Andrei Sandu <[email protected]> * fix warn Signed-off-by: Andrei Sandu <[email protected]> * typo Signed-off-by: Andrei Sandu <[email protected]> * Review feedback Signed-off-by: Andrei Sandu <[email protected]> * Finish label support Signed-off-by: Andrei Sandu <[email protected]> * fmt Signed-off-by: Andrei Sandu <[email protected]> * please compile Signed-off-by: Andrei Sandu <[email protected]> * add feature gate Signed-off-by: Andrei Sandu <[email protected]> * fmt Signed-off-by: Andrei Sandu <[email protected]> * Comment cargo toml Signed-off-by: Andrei Sandu <[email protected]> * Fix cargo toml description Signed-off-by: Andrei Sandu <[email protected]> * Update doc. Signed-off-by: Andrei Sandu <[email protected]> * switch to `runtime-metrics` feature Signed-off-by: Andrei Sandu <[email protected]> * fmt Signed-off-by: Andrei Sandu <[email protected]> * cargo toml Signed-off-by: Andrei Sandu <[email protected]> * fix tests Signed-off-by: Andrei Sandu <[email protected]> * fixes Signed-off-by: Andrei Sandu <[email protected]> * better ux Signed-off-by: Andrei Sandu <[email protected]> * from_utf8_unchecked is safe Signed-off-by: Andrei Sandu <[email protected]> * fmt Signed-off-by: Andrei Sandu <[email protected]> * Add Counter and refactor Signed-off-by: Andrei Sandu <[email protected]> * Fixes Signed-off-by: Andrei Sandu <[email protected]> * review fixes Signed-off-by: Andrei Sandu <[email protected]> * more fixes Signed-off-by: Andrei Sandu <[email protected]> * add integration test Signed-off-by: Andrei Sandu <[email protected]> * dev deps Signed-off-by: Andrei Sandu <[email protected]> * gitlab script update Signed-off-by: Andrei Sandu <[email protected]> * review fixes Signed-off-by: Andrei Sandu <[email protected]> * fix merge damage Signed-off-by: Andrei Sandu <[email protected]> * Run tests twice Signed-off-by: Andrei Sandu <[email protected]> * small fix Signed-off-by: Andrei Sandu <[email protected]> * typo Signed-off-by: Andrei Sandu <[email protected]> * cargo lock Signed-off-by: Andrei Sandu <[email protected]> * tests Signed-off-by: Andrei Sandu <[email protected]> * spellcheck happy ? Signed-off-by: Andrei Sandu <[email protected]> * more fixes Signed-off-by: Andrei Sandu <[email protected]> * Guard tracing init Signed-off-by: Andrei Sandu <[email protected]> * missing copyright Signed-off-by: Andrei Sandu <[email protected]> * update lockfile for substrate Co-authored-by: parity-processbot <>

sandreim added 7 commits December 7, 2021 16:15

Add runtime metrics provider

e5ac481

Signed-off-by: Andrei Sandu <[email protected]>

Runner changes

f2fedf5

Signed-off-by: Andrei Sandu <[email protected]>

Some sample metrics in paras_inherent

3932b89

Signed-off-by: Andrei Sandu <[email protected]>

update cargo toml

c9099e9

Signed-off-by: Andrei Sandu <[email protected]>

fmt

21c967b

Signed-off-by: Andrei Sandu <[email protected]>

bug

b6205b2

Signed-off-by: Andrei Sandu <[email protected]>

more fmt after merge

e058dc1

Signed-off-by: Andrei Sandu <[email protected]>

github-actions bot added the A3-in_progress Pull request is in progress. No review needed at this stage. label Dec 7, 2021

sandreim mentioned this pull request Dec 7, 2021

Add logger configuration hook paritytech/substrate#10440

Merged

sandreim requested a review from drahnr December 7, 2021 16:46

drahnr reviewed Dec 8, 2021

View reviewed changes

sandreim added 9 commits December 8, 2021 13:01

Refactor metric prefix override

0d9760a

Signed-off-by: Andrei Sandu <[email protected]>

fmt

ae187f7

Signed-off-by: Andrei Sandu <[email protected]>

remove bug comment

3189117

Signed-off-by: Andrei Sandu <[email protected]>

Add runtime metric primitives

561c414

Signed-off-by: Andrei Sandu <[email protected]>

Impl trace event parsing

bf5e5eb

Signed-off-by: Andrei Sandu <[email protected]>

Update metrics

e3385de

Signed-off-by: Andrei Sandu <[email protected]>

cargo lock

267fc85

Signed-off-by: Andrei Sandu <[email protected]>

fmt

82356e5

Signed-off-by: Andrei Sandu <[email protected]>

Fix target check

41c4034

Signed-off-by: Andrei Sandu <[email protected]>

drahnr reviewed Dec 8, 2021

View reviewed changes

node/metrics/src/runtime.rs Outdated Show resolved Hide resolved

drahnr reviewed Dec 9, 2021

View reviewed changes

cli/src/cli.rs Outdated Show resolved Hide resolved

sandreim added 8 commits December 9, 2021 10:27

Merge branch 'master' of github.com:paritytech/polkadot into sandreim…

a6ed5d4

…/runtime_metrics_try2

Runtime metrics primitives

6d8cb15

Signed-off-by: Andrei Sandu <[email protected]>

Review feedback

d2381ea

Signed-off-by: Andrei Sandu <[email protected]>

Runtime metrics crate

155c9b7

Signed-off-by: Andrei Sandu <[email protected]>

Node side runtime metric changes

2f27805

Signed-off-by: Andrei Sandu <[email protected]>

use runtime CounterVec instead of macro

cfd62ab

Signed-off-by: Andrei Sandu <[email protected]>

fmt nice

e6855e1

Signed-off-by: Andrei Sandu <[email protected]>

remove dead code

90b78c8

Signed-off-by: Andrei Sandu <[email protected]>

review fixes

7303a4a

Signed-off-by: Andrei Sandu <[email protected]>

sandreim requested review from drahnr and ordian December 15, 2021 12:25

drahnr approved these changes Dec 15, 2021

View reviewed changes

sandreim added 2 commits December 15, 2021 13:11

fix merge damage

796338f

Signed-off-by: Andrei Sandu <[email protected]>

Run tests twice

0b6f0f2

Signed-off-by: Andrei Sandu <[email protected]>

ordian approved these changes Dec 15, 2021

View reviewed changes

runtime/parachains/src/paras_inherent/mod.rs Outdated Show resolved Hide resolved

sandreim added 2 commits December 15, 2021 15:02

small fix

bc01068

Signed-off-by: Andrei Sandu <[email protected]>

typo

e818617

Signed-off-by: Andrei Sandu <[email protected]>

TriplEight reviewed Dec 15, 2021

View reviewed changes

scripts/gitlab/test_linux_stable.sh Outdated Show resolved Hide resolved

TriplEight self-requested a review December 15, 2021 16:23

TriplEight approved these changes Dec 15, 2021

View reviewed changes

sandreim added 3 commits December 15, 2021 16:40

cargo lock

5a1050d

Signed-off-by: Andrei Sandu <[email protected]>

tests

2febc4c

Signed-off-by: Andrei Sandu <[email protected]>

spellcheck happy ?

fecd12b

Signed-off-by: Andrei Sandu <[email protected]>

ordian added the D5-nicetohaveaudit ⚠️ PR contains trivial changes to logic that should be properly reviewed. label Dec 15, 2021

bkchr reviewed Dec 16, 2021

View reviewed changes

runtime/metrics/src/std.rs Outdated Show resolved Hide resolved

runtime/metrics/src/lib.rs Outdated Show resolved Hide resolved

drahnr mentioned this pull request Dec 16, 2021

[DO NOT MERGE] runtime filter inherent logs #4378

Closed

more fixes

0b405e0

Signed-off-by: Andrei Sandu <[email protected]>

bkchr reviewed Dec 16, 2021

View reviewed changes

primitives/src/v1/metrics.rs Show resolved Hide resolved

sandreim and others added 4 commits December 16, 2021 11:08

Guard tracing init

78620f6

Signed-off-by: Andrei Sandu <[email protected]>

missing copyright

061efe2

Signed-off-by: Andrei Sandu <[email protected]>

Merge remote-tracking branch 'origin/master' into sandreim/runtime_me…

6dae53e

…trics_try2

update lockfile for substrate

f1d515e

paritytech-processbot bot merged commit f2802d7 into master Dec 16, 2021

paritytech-processbot bot deleted the sandreim/runtime_metrics_try2 branch December 16, 2021 11:56

sandreim mentioned this pull request Dec 16, 2021

Runtime metrics boilerplate #4544

Closed

librelois mentioned this pull request Feb 7, 2022

Update substrate/polkadot/cumulus from v0.9.15 to v0.9.16 moonbeam-foundation/moonbeam#1259

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add support for wasm runtime metrics try #2 #4483

Add support for wasm runtime metrics try #2 #4483

sandreim commented Dec 7, 2021 •

edited

Loading

drahnr left a comment

drahnr left a comment

drahnr Dec 15, 2021

bkchr left a comment

paritytech-processbot bot commented Dec 16, 2021

Add support for wasm runtime metrics try #2 #4483

Add support for wasm runtime metrics try #2 #4483

Conversation

sandreim commented Dec 7, 2021 • edited Loading

drahnr left a comment

Choose a reason for hiding this comment

drahnr left a comment

Choose a reason for hiding this comment

drahnr Dec 15, 2021

Choose a reason for hiding this comment

bkchr left a comment

Choose a reason for hiding this comment

paritytech-processbot bot commented Dec 16, 2021

sandreim commented Dec 7, 2021 •

edited

Loading