Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

Relaunch Rococo #4577

Merged
merged 3 commits into from
Dec 25, 2021
Merged

Relaunch Rococo #4577

merged 3 commits into from
Dec 25, 2021

Conversation

bkchr
Copy link
Member

@bkchr bkchr commented Dec 21, 2021

Session length: 1h

Thanks for @SBalaguer for the initial commits.

@bkchr bkchr added A0-please_review Pull request needs code review. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. labels Dec 21, 2021
al3mart
al3mart approved these changes Dec 21, 2021
View reviewed changes
Copy link
Contributor

@al3mart al3mart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, works well

@ordian
Copy link
Member

ordian commented Dec 21, 2021

Does it make Versi's sessions 1h as well? We probably want to keep 10mins, but not building yet another runtime.

@bkchr
Copy link
Member Author

bkchr commented Dec 21, 2021

Does it make Versi's sessions 1h as well? We probably want to keep 10mins, but not building yet another runtime.

This doesn't change any other chain spec. However, rococo supports to change the session length dynamically. As rococo local also still runs with 1 minute session length.

@PierreBesson
Copy link
Contributor

Does it make Versi's sessions 1h as well? We probably want to keep 10mins, but not building yet another runtime.

I think it does as Versi is configured to use the Rococo chainspec definition. New configuration code might have to be written specifically for Versi chainspec.

@bkchr
Copy link
Member Author

bkchr commented Dec 22, 2021

Does it make Versi's sessions 1h as well? We probably want to keep 10mins, but not building yet another runtime.

I think it does as Versi is configured to use the Rococo chainspec definition. New configuration code might have to be written specifically for Versi chainspec.

Exported chain specs are different. However, we would need to set some value on Versi before a runtime upgrade is done.

@bkchr bkchr merged commit a75846d into master Dec 25, 2021
@bkchr bkchr deleted the bkchr-rococo-relaunch branch December 25, 2021 07:46
@bkchr bkchr mentioned this pull request Dec 25, 2021
Closed
ordian added a commit that referenced this pull request Dec 27, 2021
@ordian
Merge branch 'master' into ao-fixed-colander
0e405c2 
* master:
  make check-dependent-* only be executed in PRs (#4588)
  session_info: add dispute_period and random_seed (#4547)
  session-info: add new fields + migration (#4545)
  Bump zstd from 0.9.0+zstd.1.5.0 to 0.9.1+zstd.1.5.1 (#4597)
  Relaunch Rococo (#4577)
  Companion for substrate#9732 (#4104)
  Better logs and metrics on PoV fetching. (#4593)
drahnr pushed a commit that referenced this pull request Jan 4, 2022
@bkchr @SBalaguer @drahnr
Relaunch Rococo (#4577)
d288c3c 
* changed Rococos epoch to 1h

* Changed assigned_slots parameters to match ecosystem needs

* Update rococo chain spec

Co-authored-by: Santi Balaguer <[email protected]>
Wizdave97 pushed a commit to ComposableFi/polkadot that referenced this pull request Feb 3, 2022
@bkchr @SBalaguer @Wizdave97
Relaunch Rococo (paritytech#4577)
4d3965f 
* changed Rococos epoch to 1h

* Changed assigned_slots parameters to match ecosystem needs

* Update rococo chain spec

Co-authored-by: Santi Balaguer <[email protected]>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@al3mart al3mart al3mart approved these changes

@drahnr drahnr drahnr approved these changes

Assignees
No one assigned
Labels
A0-please_review Pull request needs code review. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@bkchr @ordian @PierreBesson @drahnr @al3mart @SBalaguer