This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
Fix checking for the ParachainHost runtime api
#4594
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The function `has_api` checks that the api + version matches, which isn't true anymore after bumping the version. The fix is to just compare the runtime api version being at least `1`.
bkchr
added
A0-please_review
ordian
approved these changes
Dec 23, 2021
|
Fixes #4584 when backported to older collators. |
ordian
added
B1-releasenotes
C3-medium
|
Would be good to mention this in release notes to make sure validators and collators are aware they need to update the client fairly quickly. |
bkchr
added
C7-high ❗️
and removed
C3-medium
Good point, but we should increase this to "High". |
drahnr
pushed a commit
that referenced
this pull request
Jan 4, 2022
The function `has_api` checks that the api + version matches, which isn't true anymore after bumping the version. The fix is to just compare the runtime api version being at least `1`.
Wizdave97
pushed a commit
to ComposableFi/polkadot
that referenced
this pull request
Feb 3, 2022
The function `has_api` checks that the api + version matches, which isn't true anymore after bumping the version. The fix is to just compare the runtime api version being at least `1`.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The function
has_apichecks that the api + version matches, whichisn't true anymore after bumping the version. The fix is to just compare
the runtime api version being at least
1.