-
Notifications
You must be signed in to change notification settings - Fork 1.6k
Fully enable bags-list pallet in polkadot runtime #4653
Conversation
does this need a new benchmark? |
Aye |
/benchmark runtime polkadot pallet_staking |
Benchmark Runtime Polkadot Pallet for branch "kiz-enable-bags-list-polkadot" with command cargo run --quiet --release --features=runtime-benchmarks -- benchmark --chain=polkadot-dev --steps=50 --repeat=20 --pallet=pallet_staking --extrinsic="*" --execution=wasm --wasm-execution=compiled --heap-pages=4096 --header=./file_header.txt --output=./runtime/polkadot/src/weights/ Toolchain: stable-x86_64-unknown-linux-gnu (default) Results
|
…kiz-enable-bags-list-polkadot
/benchmark runtime kusama pallet_staking |
/benchmark westend kusama pallet_staking |
…k --chain=polkadot-dev --steps=50 --repeat=20 --pallet=pallet_staking --extrinsic=* --execution=wasm --wasm-execution=compiled --heap-pages=4096 --header=./file_header.txt --output=./runtime/polkadot/src/weights/
Benchmark Runtime Kusama Pallet for branch "kiz-enable-bags-list-polkadot" with command cargo run --quiet --release --features=runtime-benchmarks -- benchmark --chain=kusama-dev --steps=50 --repeat=20 --pallet=pallet_staking --extrinsic="*" --execution=wasm --wasm-execution=compiled --heap-pages=4096 --header=./file_header.txt --output=./runtime/kusama/src/weights/ Toolchain: stable-x86_64-unknown-linux-gnu (default) Results
|
…kiz-enable-bags-list-polkadot
…k --chain=kusama-dev --steps=50 --repeat=20 --pallet=pallet_staking --extrinsic=* --execution=wasm --wasm-execution=compiled --heap-pages=4096 --header=./file_header.txt --output=./runtime/kusama/src/weights/
Error running benchmark: kiz-enable-bags-list-polkadot stdoutNode benchmarks only available on Substrate. |
/benchmark runtime westend kusama pallet_staking |
Benchmark Runtime Westend Pallet for branch "kiz-enable-bags-list-polkadot" with command cargo run --quiet --release --features=runtime-benchmarks -- benchmark --chain=westend-dev --steps=50 --repeat=20 --pallet=kusama pallet_staking --extrinsic="*" --execution=wasm --wasm-execution=compiled --heap-pages=4096 --header=./file_header.txt --output=./runtime/westend/src/weights/ Toolchain: stable-x86_64-unknown-linux-gnu (default) Results
ERROR: Unable to commit file ./runtime/westend/src/weights/ |
.saturating_add((235_921_000 as Weight).saturating_mul(v as Weight)) | ||
// Standard Error: 43_000 | ||
.saturating_add((37_925_000 as Weight).saturating_mul(n as Weight)) | ||
.saturating_add(T::DbWeight::get().reads(192 as Weight)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hmm have to look into this one.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
right, well, we need to lookup all bags upon each new era, and the number of bags is always bounded. Should be fine.
/benchmark runtime westend pallet_staking |
Benchmark Runtime Westend Pallet for branch "kiz-enable-bags-list-polkadot" with command cargo run --quiet --release --features=runtime-benchmarks -- benchmark --chain=westend-dev --steps=50 --repeat=20 --pallet=pallet_staking --extrinsic="*" --execution=wasm --wasm-execution=compiled --heap-pages=4096 --header=./file_header.txt --output=./runtime/westend/src/weights/ Toolchain: stable-x86_64-unknown-linux-gnu (default) Results
|
…kiz-enable-bags-list-polkadot
…k --chain=westend-dev --steps=50 --repeat=20 --pallet=pallet_staking --extrinsic=* --execution=wasm --wasm-execution=compiled --heap-pages=4096 --header=./file_header.txt --output=./runtime/westend/src/weights/
bot merge |
* Fully enable bags-list pallet in polkadot runtime * cargo run --quiet --release --features=runtime-benchmarks -- benchmark --chain=polkadot-dev --steps=50 --repeat=20 --pallet=pallet_staking --extrinsic=* --execution=wasm --wasm-execution=compiled --heap-pages=4096 --header=./file_header.txt --output=./runtime/polkadot/src/weights/ * cargo run --quiet --release --features=runtime-benchmarks -- benchmark --chain=kusama-dev --steps=50 --repeat=20 --pallet=pallet_staking --extrinsic=* --execution=wasm --wasm-execution=compiled --heap-pages=4096 --header=./file_header.txt --output=./runtime/kusama/src/weights/ * cargo run --quiet --release --features=runtime-benchmarks -- benchmark --chain=westend-dev --steps=50 --repeat=20 --pallet=pallet_staking --extrinsic=* --execution=wasm --wasm-execution=compiled --heap-pages=4096 --header=./file_header.txt --output=./runtime/westend/src/weights/ Co-authored-by: Parity Bot <[email protected]>
Some context on my last testing:
Also ran all of my scripts and tests for checking bags-list, and it all seems good. Once this is in, and working, we can lift the
22_500
limit on the staking side, namely theMaxNominators
storage items, which can be done through a governance motion, not a full runtime upgrade.