-
Notifications
You must be signed in to change notification settings - Fork 1.6k
Conversation
Thanks! A couple of things:
|
Hi @ordian, thanks for the feedback! Related to your points:
Yes, generate and perform the upgrade. I think we can use
Yes, we can agree to use a better expression.
Yes, support
Something like:
or
quick question: Do we need to be explicit about parachain Id? Thanks! |
For tests where we have more than one parachain. But we currently don't have such tests. |
bob: is up | ||
alice: parachain 100 is registered within 225 seconds | ||
alice: parachain 100 block height is at least 10 within 400 seconds | ||
alice: parachain 100 perform dummy upgrade within 200 seconds |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What's the wasm blob that is used for the upgrade?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @drahnr, for this use case we generate a new wasm
from the previous one by appending a custom section
.
A high level process definition:
Zombienet will connect to the collator and get the :code, after decompress a custom section is appended to the wasm and re-compressed. The new compressed code is used to perform the upgrade and then zombienet will try to match the new hash in the <node name> defined for x amount of seconds.
Also, as mention in the pr
this test is using polkadot-collator
and polkadot
latest image versions because I try with the image build within the pr
but doesn't work with the collator version.
Thx!
Co-authored-by: Bernhard Schuster <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice!
UPDATED cc @pepyakin / @ordian
Zombienet new available commands
<node name>
: parachain perform dummy upgrade within x secondsZombienet
will connect to thecollator
and get the:code
, after decompress acustom section
is appended to the wasm and re-compressed. The new compressed code is used to perform the upgrade and thenzombienet
will try to match the newhash
in the<node name>
defined forx
amount of seconds.<node name>
: parachain perform upgrade with within x secondsZombienet
will download thewasm
from the provided url and use it for perform the upgrade. Then will try to match the newhash
in the<node name>
defined forx
amount of seconds.NOTE: The images for the
relay chain
nodes and collator are fixed topolkadot:latest
andpolkadot-collator:latest
. I try using theparitypr
for the relay chain nodes but the collator produce this error:I'm not sure if we want to set this test to run with those fixed version in the
CI
or we want to make it works with the image produced by thepr
(docker.io/paritypr/synth-wave).Thanks!!