Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

Corrected weight trader comment #6752

Merged
merged 2 commits into from
Feb 22, 2023
Merged

Corrected weight trader comment #6752

merged 2 commits into from
Feb 22, 2023

Conversation

daredevil3435
Copy link
Contributor

corrected the weight trader comment.

@cla-bot-2021
Copy link

cla-bot-2021 bot commented Feb 21, 2023

User @daredevil3435, please sign the CLA here.

@daredevil3435
Copy link
Contributor Author

This resolves #4815 issue

@daredevil3435
Copy link
Contributor Author

Please review my code comment correction.

@bkchr bkchr requested a review from KiChjang February 22, 2023 10:04
@bkchr
Copy link
Member

bkchr commented Feb 22, 2023

bot fmt

@command-bot
Copy link

command-bot bot commented Feb 22, 2023 •
edited
Loading

@bkchr https://gitlab.parity.io/parity/mirrors/polkadot/-/jobs/2427626 was started for your command "$PIPELINE_SCRIPTS_DIR/commands/fmt/fmt.sh". Check out https://gitlab.parity.io/parity/mirrors/polkadot/-/pipelines?page=1&scope=all&username=group_605_bot to know what else is being executed currently.

Comment bot cancel 39-e49b3a8e-5274-450d-9d2f-0376a7e37f37 to cancel this command or bot cancel to cancel all commands in this pull request.

@command-bot
Copy link

command-bot bot commented Feb 22, 2023

@bkchr Command "$PIPELINE_SCRIPTS_DIR/commands/fmt/fmt.sh" has finished. Result: https://gitlab.parity.io/parity/mirrors/polkadot/-/jobs/2427626 has finished. If any artifacts were generated, you can download them from https://gitlab.parity.io/parity/mirrors/polkadot/-/jobs/2427626/artifacts/download.

@bkchr bkchr added A0-pleasereview B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit. labels Feb 22, 2023
@bkchr bkchr merged commit f07d956 into paritytech:master Feb 22, 2023
@daredevil3435 daredevil3435 mentioned this pull request Feb 23, 2023
Closed
ordian added a commit that referenced this pull request Mar 16, 2023
@ordian
Merge branch 'master' into ao-kusama-enable-dispute-slashes
7785be8 
* master: (98 commits)
  Ensure max_weight is assigned properly in AllowTopPaidExecutionFrom (#6787)
  Explicitly Handling ProvisionableData Cases (#6757)
  Companion for Substrate#12520 (#6730)
  Revert back to bare metal runners for weights generation (#6762)
  Improve XCM fuzzer (#6190)
  Corrected weight trader comment (#6752)
  clean up executed migrations (#6763)
  Remove state migration from westend runtime. (#6737)
  polkadot companion #12608 (Pools claim permissions) (#6753)
  Add Turboflakes bootnodes to Polkadot, Kusama and Westend (#6628)
  Companion for substrate#13284 (#6653)
  Companion for Substrate #13410: Introduce EnsureOrigin to democracy.propose (#6750)
  `BlockId` removal: `BlockBuilderProvider::new_block_at` (#6734)
  Companion PR for PR#13119 (#6683)
  Companion for Substrate#13411: frame/beefy: prune entries in set id session mapping (#6743)
  `BlockId` removal: refactor of runtime API (#6721)
  Fix auction bench (#6747)
  Use PVF code paired with executor params wherever possible (#6742)
  Retire `OldV1SessionInfo` (#6744)
  Companion for substrate #13121 - BEEFY Equivocations support (#6593)
  ...
@kiltbot kiltbot mentioned this pull request Apr 3, 2023
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bkchr bkchr bkchr approved these changes

@KiChjang KiChjang KiChjang approved these changes

Assignees
No one assigned
Labels
B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@daredevil3435 @bkchr @KiChjang