XCM: Properly set the pricing for the DMP router #6843

KiChjang · 2023-03-08T13:07:25Z

This PR properly adds a delivery fee to the DMP router used by the relay chain. It uses a base fee of CENTS * 3, and is then multiplied by 1.01 to the power of the number of pending messages in the message queue of the destination. Such a formula is intended to make the fees cheap initially when the queue is small, but would get prohibitively expensive relatively quickly.

runtime/kusama/src/xcm_config.rs

kianenigma · 2023-04-11T09:03:40Z

runtime/parachains/src/dmp.rs

@@ -14,13 +14,34 @@
 // You should have received a copy of the GNU General Public License
 // along with Polkadot.  If not, see <http://www.gnu.org/licenses/>.

+//! To prevent Out of Memory errors on the `DownwardMessageQueue`,


formatting and line wrapping in this doc comment is somewhat not on par with the rest of the code; always been suggesting using https://marketplace.visualstudio.com/items?itemName=stkb.rewrap or similar.

Some spacing would also help; see this line from this PR as an inspiration.

kianenigma · 2023-04-11T09:06:32Z

runtime/parachains/src/dmp.rs


+	/// The number to multiply the base delivery fee by.
+	#[pallet::storage]
+	#[pallet::getter(fn delivery_fee_factor)]


getters are being deprecated: please don't add more :D

https://github.com/paritytech/substrate/issues/13259

bkchr · 2023-04-13T21:14:19Z

runtime/westend/Cargo.toml

@@ -26,6 +26,7 @@ sp-io = { git = "https://github.com/paritytech/substrate", branch = "master", de
 sp-mmr-primitives = { git = "https://github.com/paritytech/substrate", branch = "master", default-features = false }
 sp-runtime = { git = "https://github.com/paritytech/substrate", branch = "master", default-features = false }
 sp-staking = { git = "https://github.com/paritytech/substrate", branch = "master", default-features = false }
+sp-arithmetic = { git = "https://github.com/paritytech/substrate", branch = "master", default-features = false }


Not being used?

bkchr · 2023-04-13T21:14:28Z

runtime/rococo/Cargo.toml

@@ -27,6 +27,7 @@ sp-io = { git = "https://github.com/paritytech/substrate", branch = "master", de
 sp-mmr-primitives = { git = "https://github.com/paritytech/substrate", branch = "master", default-features = false }
 sp-runtime = { git = "https://github.com/paritytech/substrate", branch = "master", default-features = false }
 sp-staking = { git = "https://github.com/paritytech/substrate", branch = "master", default-features = false }
+sp-arithmetic = { git = "https://github.com/paritytech/substrate", branch = "master", default-features = false }


kianenigma

Thanks for the well-documented PR! 💯

kianenigma · 2023-04-19T15:09:53Z

runtime/kusama/src/lib.rs

@@ -1410,7 +1410,7 @@ construct_runtime! {
 		ParaScheduler: parachains_scheduler::{Pallet, Storage} = 55,
 		Paras: parachains_paras::{Pallet, Call, Storage, Event, Config, ValidateUnsigned} = 56,
 		Initializer: parachains_initializer::{Pallet, Call, Storage} = 57,
-		Dmp: parachains_dmp::{Pallet, Call, Storage} = 58,
+		Dmp: parachains_dmp::{Pallet, Storage} = 58,


this could be all refactored to use default parts in the future, no?

runtime/parachains/src/dmp.rs

Co-authored-by: Kian Paimani <[email protected]>

vstam1 · 2023-04-20T11:04:25Z

bot merge

* master: (30 commits) update rocksdb to 0.20.1 (#7113) Reduce base proof size weight component to zero (#7081) PVF: Move PVF workers into separate crate (#7101) Companion for #13923 (#7111) update safe call filter (#7080) PVF: Don't dispute on missing artifact (#7011) XCM: Properly set the pricing for the DMP router (#6843) pvf: Update docs for PVF artifacts (#6551) Bump syn from 2.0.14 to 2.0.15 (#7093) Companion for substrate#13771 (#6983) Added Dwellir Nigeria bootnodes. (#7097) Companion for Substrate #13889 (#7063) Switch to DNS name based bootnodes for Rococo (#7040) companion for substrate#13883 (#7059) [xcm] Added `UnpaidExecution` instruction to `UnpaidRemoteExporter` (#7091) Bump serde_json from 1.0.85 to 1.0.96 (#7072) Bump hex-literal from 0.3.4 to 0.4.1 (#7071) Small simplification (#7089) [XCM - UnpaidRemoteExporter] Remove unreachable code (#7088) sync versions with current release (#7083) ...

* master: (39 commits) malus: dont panic on missing validation data (#6952) Offences Migration v1: Removes `ReportsByKindIndex` (#7114) Fix stalling dispute coordinator. (#7125) Fix rolling session window (#7126) [ci] Update buildah command and version (#7128) Bump assigned_slots params (#6991) XCM: Remote account converter (#6662) Rework `dispute-coordinator` to use `RuntimeInfo` for obtaining session information instead of `RollingSessionWindow` (#6968) Revert default proof size back to 64 KB (#7115) update rocksdb to 0.20.1 (#7113) Reduce base proof size weight component to zero (#7081) PVF: Move PVF workers into separate crate (#7101) Companion for #13923 (#7111) update safe call filter (#7080) PVF: Don't dispute on missing artifact (#7011) XCM: Properly set the pricing for the DMP router (#6843) pvf: Update docs for PVF artifacts (#6551) Bump syn from 2.0.14 to 2.0.15 (#7093) Companion for substrate#13771 (#6983) Added Dwellir Nigeria bootnodes. (#7097) ...

Properly set the pricing for the DMP router

145af81

paritytech-ci requested review from a team March 8, 2023 13:07

KiChjang added T1-runtime This PR/Issue is related to the topic “runtime”. T6-XCM This PR/Issue is related to XCM. and removed T1-runtime This PR/Issue is related to the topic “runtime”. T6-XCM This PR/Issue is related to XCM. labels Mar 8, 2023

Publicize price types

d489025

ggwpez reviewed Mar 8, 2023

View reviewed changes

runtime/kusama/src/xcm_config.rs Outdated Show resolved Hide resolved

KiChjang added 3 commits March 9, 2023 00:31

Use FixedU128 instead of Percent

39f90fe

Add sp-arithmetic as a dependency for rococo runtime

824f045

Add sp-arithmetic as a dependency to all runtimes

f4e0d66

gavofyork mentioned this pull request Mar 9, 2023

XCM: Message Queues paritytech/polkadot-sdk#489

Open

7 tasks

KiChjang added 9 commits March 9, 2023 01:40

Remove duplicate import

7a49275

Add missing import

59d6693

Fix tests

500b42f

Create an appropriate QueueDownwardMessageError variant

633430c

Recalculate delivery fee factor based on past queue sizes

7f27521

Remove unused error variant

2fe3547

Fixes

3f6ea59

Fixes

c36de96

Remove unused imports

7e3d876

ggwpez reviewed Mar 10, 2023

View reviewed changes

runtime/kusama/src/xcm_config.rs Outdated Show resolved Hide resolved

Rewrite fee factor update mechanism

c5a622d

fmt

d0c5de1

sam0x17 approved these changes Apr 3, 2023

View reviewed changes

franciscoaguirre approved these changes Apr 3, 2023

View reviewed changes

bkontur reviewed Apr 4, 2023

View reviewed changes

runtime/kusama/src/xcm_config.rs Outdated Show resolved Hide resolved

change to tokenlocation

ea42774

KiChjang mentioned this pull request Apr 6, 2023

Update UI to reflect DMP/HRMP message delivery fees polkadot-js/apps#9298

Open

kianenigma reviewed Apr 11, 2023

View reviewed changes

paritytech-ci requested a review from a team April 11, 2023 09:04

kianenigma reviewed Apr 11, 2023

View reviewed changes

paritytech-ci requested a review from a team April 11, 2023 09:06

vstam1 added 2 commits April 11, 2023 13:35

small fixes

1732846

fmt

56fe04d

sam0x17 approved these changes Apr 11, 2023

View reviewed changes

vstam1 requested a review from kianenigma April 11, 2023 16:48

bkchr approved these changes Apr 13, 2023

View reviewed changes

paritytech-ci requested a review from a team April 13, 2023 21:37

vstam1 added 2 commits April 14, 2023 11:31

remove sp_arithmetic dependency

2f7acd1

Merge branch 'master' into kckyeung/xcm-sender-price

8b4877a

kianenigma approved these changes Apr 19, 2023

View reviewed changes

Update runtime/parachains/src/dmp.rs

a7e5ded

Co-authored-by: Kian Paimani <[email protected]>

paritytech-processbot bot merged commit a5e253d into master Apr 20, 2023

paritytech-processbot bot deleted the kckyeung/xcm-sender-price branch April 20, 2023 11:04

github-actions bot mentioned this pull request Jun 15, 2023

Update substrate/polkadot/cumulus from v0.9.40 to v0.9.43 moonbeam-foundation/moonbeam#2354

Closed

svyatonik mentioned this pull request Jul 24, 2023

Dynamic fees for bridges-v1 paritytech/parity-bridges-common#2294

Merged

9 tasks

gilescope mentioned this pull request Aug 30, 2023

Introduce XcmFeesToAccount fee manager paritytech/polkadot-sdk#1234

Merged

franciscoaguirre mentioned this pull request Sep 14, 2023

Add UMP pricing paritytech/polkadot-sdk#1556

Merged

2 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

XCM: Properly set the pricing for the DMP router #6843

XCM: Properly set the pricing for the DMP router #6843

KiChjang commented Mar 8, 2023

kianenigma Apr 11, 2023

kianenigma Apr 11, 2023 •

edited

Loading

kianenigma Apr 11, 2023

bkchr Apr 13, 2023

bkchr Apr 13, 2023

kianenigma left a comment

kianenigma Apr 19, 2023

vstam1 commented Apr 20, 2023

XCM: Properly set the pricing for the DMP router #6843

XCM: Properly set the pricing for the DMP router #6843

Conversation

KiChjang commented Mar 8, 2023

kianenigma Apr 11, 2023

Choose a reason for hiding this comment

kianenigma Apr 11, 2023 • edited Loading

Choose a reason for hiding this comment

kianenigma Apr 11, 2023

Choose a reason for hiding this comment

bkchr Apr 13, 2023

Choose a reason for hiding this comment

bkchr Apr 13, 2023

Choose a reason for hiding this comment

kianenigma left a comment

Choose a reason for hiding this comment

kianenigma Apr 19, 2023

Choose a reason for hiding this comment

vstam1 commented Apr 20, 2023

kianenigma Apr 11, 2023 •

edited

Loading