This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
approval-distribution: Add approvals/assignments spans on all paths #7317
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The approval and assignment logic gets called from multiple paths, so make sure we create a tracing span on all paths to make debugging easier and be able and correlate with the spans from approval-voting. Signed-off-by: Alexandru Gheorghe <[email protected]>
alexggh
added
A0-please_review
Signed-off-by: Alexandru Gheorghe <[email protected]>
sandreim
reviewed
May 31, 2023
Use the source to determine the tag name Signed-off-by: Alexandru Gheorghe <[email protected]>
alexggh
commented
Jun 1, 2023
sandreim
approved these changes
Jun 2, 2023
| @@ -277,7 +277,7 @@ impl Span { | |||
| } | |||
|
|
|||
| /// Derive a child span from `self`. | |||
| pub fn child(&self, name: &'static str) -> Self { | |||
| pub fn child(&self, name: &str) -> Self { | |||
There was a problem hiding this comment.
This could still be static if you use match / if let when creating the span.
There was a problem hiding this comment.
Yes, it can be static, but it doesn't makes sense to be starting here since inner.child doesn't have this restriction.
bredamatt
approved these changes
Jun 5, 2023
lexnv
approved these changes
Jun 6, 2023
|
bot merge |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The approval and assignment logic gets called from multiple paths, so make sure we create a tracing span on all paths to make debugging easier and be able and correlate with the spans from approval-voting.