Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

PVF: Add missing crate descriptions #7587

Merged
merged 3 commits into from
Aug 8, 2023
Merged

PVF: Add missing crate descriptions #7587

merged 3 commits into from
Aug 8, 2023

Conversation

mrcnski
Copy link
Contributor

@mrcnski mrcnski commented Aug 7, 2023

@mrcnski mrcnski added I7-documentation Documentation needs fixing, improving or augmenting. A0-please_review Pull request needs code review. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit. labels Aug 7, 2023
s0me0ne-unkn0wn
s0me0ne-unkn0wn approved these changes Aug 7, 2023
View reviewed changes
Copy link
Contributor

@s0me0ne-unkn0wn s0me0ne-unkn0wn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

coderobe
coderobe approved these changes Aug 7, 2023
View reviewed changes
Copy link
Contributor

@coderobe coderobe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: as these are the descriptions visible on crates.io, maybe they should mention polkadot in the description text

@mrcnski
Copy link
Contributor Author

mrcnski commented Aug 7, 2023

Done @coderobe

@paritytech-cicd-pr
Copy link

The CI pipeline was cancelled due to failure one of the required jobs.
Job name: test-linux-stable
Logs: https://gitlab.parity.io/parity/mirrors/polkadot/-/jobs/3341142

@mrcnski mrcnski merged commit a0f986f into master Aug 8, 2023
5 checks passed
@mrcnski mrcnski deleted the mrcnski/pvf-add-crate-descriptions branch August 8, 2023 13:51
s0me0ne-unkn0wn pushed a commit that referenced this pull request Aug 15, 2023
@mrcnski @s0me0ne-unkn0wn
PVF: Add missing crate descriptions (#7587)
929e2d4
@crystalin crystalin mentioned this pull request Oct 20, 2023
Closed
@JesseAbram JesseAbram mentioned this pull request Oct 26, 2023
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@s0me0ne-unkn0wn s0me0ne-unkn0wn s0me0ne-unkn0wn approved these changes

@Morganamilo Morganamilo Morganamilo approved these changes

@ggwpez ggwpez ggwpez approved these changes

@coderobe coderobe coderobe approved these changes

Assignees
No one assigned
Labels
A0-please_review Pull request needs code review. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit. I7-documentation Documentation needs fixing, improving or augmenting.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@mrcnski @paritytech-cicd-pr @coderobe @ggwpez @Morganamilo @s0me0ne-unkn0wn