-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump parity-scale-codec to 2.2.0-rc.2 #102
Conversation
If we merge this, can we get a release out that contains this PR? If so, can we release straight from |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since it is including a pre-release dependency, we would have to make a pre-release version here to prevent users requiring 2.2.0-rc.*
If it was a full 2.2.0
release then it would resolve okay for scale-info
0.6
since the constraint is ^2.0
.
I do plan on making a 0.7
release soon (as soon as #96 is merged), so could make a 0.7-rc.0
to include this, if it can wait until early next week?
Otherwise we will have to apply this patch to the 0.6
release commit and make a release just containing this.
Are you able to do:
[patch.crates-io]
scale-info = { git = "https://github.com/paritytech/scale-info", branch = "igor-use-new-codec" }
in the substrate PR for now as a temporary workaround?
Would you consider releasing
We're using patches already in paritytech/substrate#9163 to test if everything works together nicely but since the goal is to unbreak and resume publishing of the Substrate crates, I'm trying to bump the transitive dependency versions and release them to only depend on crates.io-released stuff. |
If I'm unable to get #96 merged by tomorrow then I will do an interim
Note that I won't do an |
Yeah, that makes perfect sense. Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Working towards getting a release out today or early next week
Though I'm considering releasing I will do the release on Monday. |
That makes sense. Then, I'll pull the |
Apologies, I am still waiting for another approval to merge #96 in order to do the releases a promised. I could hack together an interim release but it is a bit late in the day for that, and I want to avoid a messy release history as much as possible. We will resolve this one way or another tomorrow so you can be unblocked on this. |
* Add 0.7.0-rc.0 release section to CHANGELOG.md * Add codec bump to CHANGELOG * Make it 0.7.0, comment about `codec` `2.2.0-alpha` * Bump versions * Revert codec upgrade * Revert "Bump parity-scale-codec to 2.2.0-rc.2 (#102)" This reverts commit 279f3fa * Update release date * Relax parity-scale-codec version requirements
* Bump parity-scale-codec to 2.2.0-rc.2 * Bump codec in derive-tests-no-std crate as well (cherry picked from commit 279f3fa)
* Bump parity-scale-codec to 2.2.0-rc.2 (#102) * Bump parity-scale-codec to 2.2.0-rc.2 * Bump codec in derive-tests-no-std crate as well (cherry picked from commit 279f3fa) * Bump version and update changelog Co-authored-by: Igor Matuszewski <[email protected]>
Part of paritytech/substrate#9163.
Needed to bump
parity-scale-codec
version used by theprimitive-types
crate, which in turn needs a new version in order to implement a newcodec::MaxEncodedLen
trait as part of the paritytech/substrate#9163 migration.