Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Option constructor macro hygiene #108

Merged
merged 4 commits into from
Jul 6, 2021
Merged

Option constructor macro hygiene #108

merged 4 commits into from
Jul 6, 2021

Conversation

ascjones
Copy link
Contributor

@ascjones ascjones commented Jul 6, 2021

Fully qualify Option constructors to avoid collisions.

Copy link
Contributor

@Robbepop Robbepop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch!

@ascjones
Copy link
Contributor Author

ascjones commented Jul 6, 2021

good catch!

Compiler caught it for me in polkadot 🙈

@ascjones ascjones merged commit f8c56b9 into master Jul 6, 2021
@ascjones ascjones deleted the aj-option-hygiene branch July 6, 2021 09:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants