Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add range getters, combine start and end types #126

Merged
merged 2 commits into from
Aug 25, 2021
Merged

Conversation

ascjones
Copy link
Contributor

@ascjones ascjones commented Aug 24, 2021

Follow up to #124

Getters are required for the range fields, since they are private.

Also I have combined the start and end fields because they are always the same type.

@ascjones ascjones requested a review from dvdplm August 24, 2021 17:11
Copy link
Contributor

@dvdplm dvdplm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@dvdplm dvdplm merged commit 56d24a2 into master Aug 25, 2021
@dvdplm dvdplm deleted the aj-range-getters branch August 25, 2021 07:02
This was referenced Aug 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants