fix!: integrate @substrate/[email protected] for partial fees

[TarikGul]

Summary (BREAKING CHANGES)

This PR focuses on adding calc_partial_fee from @substrate/calc v0.3.0 so that fee calculations for both relay and parachains are completely accurate. It uses a combination of both payment_queryInfo and payment_queryFeeDetails in order to calculate the fee. If payment_queryFeeDetails is not present or available to use, it will default to payment_queryInfo. This PR also adds a field to the info of an extrinsic called kind which can either be preDispatch, or postDispatch. More Info below.

Removed

• Breaking Change - Remove feeByEvent query param as it is no longer needed as Sidecar now has the accuracy it needs for fees. In the future if the event TransactionFeePaid is present it will take the fee from there.

Added

• kind: 'preDispatch' | 'postDispatch' field in info for extrinsics.

  1. preDispatch: payment_queryInfo was used to get the partialFee given preDispatch information.
  2. postDispatch: calc_partial_fee was used to calculate the fee using post dispatch fee information.

• calc_partial_fee: /blocks/* now uses this method to accurately calculate partialFee's for extrinsics.

Fixed

• Pass in the previous blockHash for an extrinsic query for payment_queryInfo

Notes

• Since there is no real way to evaluate if payment_queryFeeDetails is available in the runtime, and polkadot-js will throw an error regardless of catching it. Therefore we log a warning after the error is emitted to let users know the error is not important, than we cache the runtime to not call payment_queryFeeDetails again and instead recieve the partialFee from queryInfo.

Todo

• e2e-tests
• Ensure Docs are complete
• Find out what can be done to correctly handle payment_queryFeeDetails for a runtime that doesn't support it.
  • 1. We cant catch the error from polkadot-js rpc call. It will log regardless of handling it.

[niklasad1]

As a side-not to this PR when paritytech/substrate#11648 is a thing I guess it would simplify things for us.

[niklasad1]

looks alright, I think the QueryFeeDetailsCache would benefit with some additional docs such that "this is a workaround" because it's not possible to fetch which runtime APIs are available.

[jsdw]

Awesome!