Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

Remove all non-runtime uses of Ext #705

Closed
gavofyork opened this issue Sep 10, 2018 · 0 comments
Closed

Remove all non-runtime uses of Ext #705

gavofyork opened this issue Sep 10, 2018 · 0 comments
Assignees
@gavofyork
Labels
U2-some_time_soon Issue is worth doing soon. Z2-medium Can be fixed by a coder with good Rust knowledge but little knowledge of the codebase.
Milestone
1.0 beta

Comments

@gavofyork
Copy link
Member

Ext will panic when the storage root is not around, so unless you know that it is, you should not be using Ext. We need to sweep the codebase for all instantiations of Ext that are not there specifically to manage runtime externalities and replace with a call direct to the backend. Don't worry though; it's easy - see #704 for an example.
@gavofyork gavofyork added I3-bug The node fails to follow expected behavior. U2-some_time_soon Issue is worth doing soon. Z2-medium Can be fixed by a coder with good Rust knowledge but little knowledge of the codebase. labels Sep 10, 2018
@gavofyork gavofyork added this to the 1.0 beta milestone Sep 10, 2018
@gavofyork gavofyork added F1-panic and removed I3-bug The node fails to follow expected behavior. labels Sep 11, 2018
@gavofyork gavofyork self-assigned this Sep 11, 2018
@gavofyork gavofyork mentioned this issue Sep 11, 2018
Merged
liuchengxu pushed a commit to chainx-org/substrate that referenced this issue Aug 23, 2021
@atenjin
change fisher storage mark is H512 (paritytech#705)
725016b 
* change fisher storage mark is H512

* Reduce Check condition
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@gavofyork gavofyork

Labels
U2-some_time_soon Issue is worth doing soon. Z2-medium Can be fixed by a coder with good Rust knowledge but little knowledge of the codebase.
Projects
None yet
Milestone
1.0 beta
Development

No branches or pull requests
1 participant
@gavofyork