Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

Build Error due to openssl 0.9.24 #886

Closed
adrianbrink opened this issue Oct 6, 2018 · 4 comments
Closed

Build Error due to openssl 0.9.24 #886

adrianbrink opened this issue Oct 6, 2018 · 4 comments
Labels
Z0-trivial Writing the issue is of the same difficulty as patching the code.
Milestone
1.0 beta

Comments

@adrianbrink
Copy link

On macOS 10.14 (Mojave) running cargo build fails with

➜  substrate git:(master) cargo build
   Compiling openssl v0.9.24
   Compiling sr-io v0.1.0 (/Users/adrian/Desktop/code/polkadot/substrate/core/sr-io)
   Compiling safe-mix v1.0.0
   Compiling sr-sandbox v0.1.0 (/Users/adrian/Desktop/code/polkadot/substrate/core/sr-sandbox)
   Compiling trie-db v0.9.0 (https://github.com/paritytech/trie#b3b3209e)
   Compiling kvdb v0.1.0
   Compiling getset v0.0.6
   Compiling parking_lot v0.4.8
error: failed to run custom build command for `openssl v0.9.24`
process didn't exit successfully: `/Users/adrian/Desktop/code/polkadot/substrate/target/debug/build/openssl-6d9e1e02e1314785/build-script-build` (exit code: 101)
--- stderr
thread 'main' panicked at 'Unable to detect OpenSSL version', /Users/adrian/.cargo/registry/src/github.com-1ecc6299db9ec823/openssl-0.9.24/build.rs:16:14
note: Run with `RUST_BACKTRACE=1` for a backtrace.

warning: build failed, waiting for other jobs to finish...
error: build failed

This issue is also described in #800 . Both openssl and libressl are installed with brew install openssl libressl.

The openssl v0.9.24 and openssl-sys v0.9.33 are pulled in through ws 0.7.8.

The two approaches I can currently think of are:

  1. Overriding the openssl dependency with patch or replace
  2. Upgrading ws to a later version.
@gavofyork
Copy link
Member

Ok - so I guess we just need to upgrade ws then. @maciejhirsz ?

@gavofyork gavofyork added Z0-trivial Writing the issue is of the same difficulty as patching the code. F5-task labels Oct 7, 2018
@gavofyork gavofyork added this to the 1.0 beta milestone Oct 7, 2018
@bkchr
Copy link
Member

bkchr commented Oct 9, 2018

I looked into this and we are using already the latest version of ws. So, patching/replacing is currently the only way for solving this. :(

@bkchr bkchr mentioned this issue Oct 16, 2018
Merged
@gavofyork
Copy link
Member

fixed.

@adrianbrink
Copy link
Author

Confirmed the fix on macOS 10.14.

@adrianbrink adrianbrink mentioned this issue Oct 18, 2018
Closed
@bohendo bohendo mentioned this issue Nov 17, 2018
Closed
@flyq flyq mentioned this issue Jan 28, 2020
Closed
lamafab pushed a commit to lamafab/substrate that referenced this issue Jun 16, 2020
@gavofyork
Update to Substrate master (paritytech#886)
ab76ea7 
* Bump Substrate and some fixes

* Bump runtime

* version bump
helin6 pushed a commit to boolnetwork/substrate that referenced this issue Jul 25, 2023
@jsdw @niklasad1
Add 'Static' type and improve type substitution codegen to accept it (p…
a2b8dde 
…aritytech#886)

* Add Static type which defers to Encode/Decode and impls EncodeAsType/DecodeAsType

* rename to static_type and impl Deref/Mut

* Improve type substitution in codegen so that concrete types can be swapped in

* A couple of comment tweaks and no need for a macro export

* Extend type substitution logic to work recursively on destination type

* cargo fmt

* Fix a couple of comments

* update ui test outpuot

* Add docs and missing_docs lint

* Add test for replacing multiple of Ident

* Update codegen/src/error.rs

Co-authored-by: Niklas Adolfsson <[email protected]>

* update copyright year and fix ui test

* simplify another error

---------

Co-authored-by: Niklas Adolfsson <[email protected]>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
Z0-trivial Writing the issue is of the same difficulty as patching the code.
Projects
None yet
Milestone
1.0 beta
Development

No branches or pull requests
3 participants
@gavofyork @bkchr @adrianbrink