This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
Make New Storage Layer Truly Default #11918
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shawntabrizi
added
the
D9-needsaudit 👮
shawntabrizi
changed the title
shawntabrizi
added
B7-runtimenoteworthy
C1-low
bkchr
approved these changes
Jul 26, 2022
ggwpez
reviewed
Jul 26, 2022
ggwpez
approved these changes
Jul 26, 2022
|
bot merge |
|
Waiting for commit status. |
|
Merge cancelled due to error. Error: Statuses failed for 8f87c2c |
|
bot rebase |
|
Rebased |
|
bot merge |
|
can we now remove the manual |
jakoblell
added
D1-audited 👍
DaviRain-Su
pushed a commit
to octopus-network/substrate
that referenced
this pull request
Aug 23, 2022
* with storage layer truly default * fmt Co-authored-by: parity-processbot <>
6 tasks
2 tasks
ark0f
pushed a commit
to gear-tech/substrate
that referenced
this pull request
Feb 27, 2023
* with storage layer truly default * fmt Co-authored-by: parity-processbot <>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR simplifies the use of the Transactional Storage APIs introduced in #11431
The creation of a new storage layer is trivial enough that it can just be enabled by default, and thus avoid the use of
in_storage_layer, and the need for aDispatchWithStorageLayertraits.This also makes it more clear exactly what happens when you dispatch a call, no matter if you are already in a dispatchable or not.