Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

BlockId removal: refactor: StorageProvider #12510

Merged
merged 8 commits into from
Oct 18, 2022

Conversation

michalkucharczyk
Copy link
Contributor

@michalkucharczyk michalkucharczyk commented Oct 17, 2022

It changes the arguments of Backend::StorageProvider trait from:
block: BlockId<Block> to: hash: &Block::Hash

This PR is part of BlockId::Number refactoring analysis (paritytech/polkadot-sdk#53)

polkadot companion: paritytech/polkadot#6160
cumulus companion: paritytech/cumulus#1770

It changes the arguments of `Backend::StorageProvider` trait from:
block: `BlockId<Block>` to: hash: `&Block::Hash`

This PR is part of BlockId::Number refactoring analysis (paritytech/substrate#11292)
@michalkucharczyk michalkucharczyk added A0-please_review Pull request needs code review. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit labels Oct 17, 2022
@michalkucharczyk michalkucharczyk requested a review from a team October 17, 2022 12:20
client/cli/src/commands/export_state_cmd.rs Show resolved Hide resolved
client/finality-grandpa/src/import.rs Outdated Show resolved Hide resolved
client/service/test/src/client/mod.rs Outdated Show resolved Hide resolved
client/service/test/src/client/mod.rs Outdated Show resolved Hide resolved
Copy link
Contributor

@dmitry-markin dmitry-markin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Is it possible to move block hash from BlockId lookup one level up out of the functions affected, so that there is no HeaderBackend constraint added? Or is it planned for the next iterations of the refactoring?

client/api/src/backend.rs Outdated Show resolved Hide resolved
client/cli/src/commands/export_state_cmd.rs Show resolved Hide resolved
client/service/src/chain_ops/export_raw_state.rs Outdated Show resolved Hide resolved
@michalkucharczyk
Copy link
Contributor Author

bot merge

@paritytech-processbot paritytech-processbot bot merged commit e34b840 into master Oct 18, 2022
@paritytech-processbot paritytech-processbot bot deleted the mku-blockid-storage branch October 18, 2022 12:52
ark0f pushed a commit to gear-tech/substrate that referenced this pull request Feb 27, 2023
* BlockId removal: refactor: StorageProvider

It changes the arguments of `Backend::StorageProvider` trait from:
block: `BlockId<Block>` to: hash: `&Block::Hash`

This PR is part of BlockId::Number refactoring analysis (paritytech/substrate#11292)

* Apply suggestions from code review

Co-authored-by: Bastian Köcher <[email protected]>

* Update client/api/src/backend.rs

Co-authored-by: Dmitrii Markin <[email protected]>

* GrandpaBlockImport::current_set_id reworked

* ExportStateCmd reworked

* trigger CI job

* trigger CI job

Co-authored-by: Bastian Köcher <[email protected]>
Co-authored-by: Dmitrii Markin <[email protected]>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A0-please_review Pull request needs code review. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit
Projects
Status: done
Development

Successfully merging this pull request may close these issues.

5 participants