chore: move genesis block builder to chain-spec crate. #13427

yjhmelody · 2023-02-21T06:47:42Z

The genesis block builder is very useful. It should not be defined in sc-service.

The logic is better in sc-block-builder. And it's useful to reduce deps when import genesis block builder logic.

bkchr · 2023-02-22T12:53:12Z

The genesis block builder is very useful. It should not be defined in sc-service.

For what else are you using it?

yjhmelody · 2023-02-23T08:10:42Z

The genesis block builder is very useful. It should not be defined in sc-service.

For what else are you using it?

I need to build genesis block for checking genesis hash in local(not in cmd).

It will be helpful if chain spec have genesis hash directly. But it seems not easy, so we should just build genesis block.

client/block-builder/src/lib.rs

koute · 2023-02-23T10:04:36Z

client/block-builder/src/lib.rs

+				state.finish().to_le_bytes().to_vec()
+			},
+		};
+		let runtime_version = RuntimeVersionOf::runtime_version(executor, &mut ext, &runtime_code)


Have you considered using ReadRuntimeVersion trait + a manual decode instead? I think that could probably work? And it wouldn't require all of the fiddling with WrappedRuntimeCode and RuntimeCode.

bkchr

I just realized that I wanted to have it put into some different crate. I think sc-chain-spec is better suited for this. Block builder is not really related to what you are doing here.

yjhmelody · 2023-02-24T03:32:15Z

Hi @bkchr I found some inconsistecy about state version here:

Genesis block always use V0 to construct tx. Should it be config?
Genesis block in test-utils use V1 to construct trie. But use V0 to construct tx.
For new chain, should we always use V1?

yjhmelody · 2023-02-24T03:35:30Z

I just realized that I wanted to have it put into some different crate. I think sc-chain-spec is better suited for this. Block builder is not really related to what you are doing here.

It is done.

bkchr

Ty!

client/chain-spec/src/genesis.rs

test-utils/runtime/client/src/lib.rs

test-utils/runtime/src/genesismap.rs

bkchr · 2023-02-24T08:59:30Z

Genesis block always use V0 to construct tx. Should it be config?

Ty for fixing this! This was an oversight!

Co-authored-by: Bastian Köcher <[email protected]>

yjhmelody · 2023-02-24T15:15:14Z

Genesis block always use V0 to construct tx. Should it be config?

Ty for fixing this! This was an oversight!

Fine, Could you edit the PR title for this fix.

melekes

👍

bkchr · 2023-02-25T11:46:49Z

@yjhmelody could you please fix the warnings?

bkchr · 2023-02-27T10:15:02Z

The CI pipeline was cancelled due to failure one of the required jobs. Job name: test-linux-stable-int Logs: https://gitlab.parity.io/parity/mirrors/substrate/-/jobs/2450835

@yjhmelody still the same warning as before.

yjhmelody · 2023-02-28T10:41:23Z

Now it's ready @bkchr

bkchr · 2023-02-28T19:51:05Z

TY @yjhmelody

* chore: move genesis block builder to block builder crate. * add missing file * chore: move genesis block builder to sc-chain-spec * Update client/chain-spec/src/genesis.rs Co-authored-by: Bastian Köcher <[email protected]> * Update test-utils/runtime/src/genesismap.rs Co-authored-by: Bastian Köcher <[email protected]> * Update test-utils/runtime/client/src/lib.rs * fix warnings * fix warnings --------- Co-authored-by: Bastian Köcher <[email protected]>

- Use of `#[pallet::generate_store(pub(super) trait Store)]` will be removed soon, paritytech/substrate#13535 - Update return values and arguments, b/c syncing protocol was extracted from sc-network. See paritytech/substrate#12828 - Update call to construct_genesis_block(), see paritytech/substrate#13427 - Use of deprecated associated function `frame_support::dispatch::Weight::from_ref_time`: Will be removed soon; use `from_parts` instead.

) * chore: move genesis block builder to block builder crate. * add missing file * chore: move genesis block builder to sc-chain-spec * Update client/chain-spec/src/genesis.rs Co-authored-by: Bastian Köcher <[email protected]> * Update test-utils/runtime/src/genesismap.rs Co-authored-by: Bastian Köcher <[email protected]> * Update test-utils/runtime/client/src/lib.rs * fix warnings * fix warnings --------- Co-authored-by: Bastian Köcher <[email protected]>

- Use of `#[pallet::generate_store(pub(super) trait Store)]` will be removed soon, paritytech/substrate#13535 - Update return values and arguments, b/c syncing protocol was extracted from sc-network. See paritytech/substrate#12828 - Update call to construct_genesis_block(), see paritytech/substrate#13427 - Use of deprecated associated function `frame_support::dispatch::Weight::from_ref_time`: Will be removed soon; use `from_parts` instead.

) * chore: move genesis block builder to block builder crate. * add missing file * chore: move genesis block builder to sc-chain-spec * Update client/chain-spec/src/genesis.rs Co-authored-by: Bastian Köcher <[email protected]> * Update test-utils/runtime/src/genesismap.rs Co-authored-by: Bastian Köcher <[email protected]> * Update test-utils/runtime/client/src/lib.rs * fix warnings * fix warnings --------- Co-authored-by: Bastian Köcher <[email protected]>

* Implements dynamic nominations per nominator * Adds SnapshotBounds and ElectionSizeTracker * Changes the ElectionDataProvider interface to receive ElectionBounds as input * Implements get_npos_voters with ElectionBounds * Implements get_npos_targets with ElectionBounds * Adds comments * tests * Truncates nomninations that exceed nominations quota; Old tests passing * Uses DataProviderBounds and ElectionBounds (to continue) * Finishes conversions - tests passing * Refactor staking in babe mocks * Replaces MaxElectableTargets and MaxElectingVoters with ElectionBounds; Adds more tests * Fixes nits; node compiling * bechmarks * removes nomination_quota extrinsic to request the nomination quota * Lazy quota check, ie. at nominate time only * remove non-working test (for now) * tests lazy nominations quota when quota is lower than current number of nominated targets * Adds runtime API and custom RPC call for clients to query the nominations quota for a given balance * removes old rpc * Cosmetic touches * All mocks working * Fixes benchmarking mocks * nits * more tests * renames trait methods * nit * ".git/.scripts/commands/fmt/fmt.sh" * Fix V2 PoV benchmarking (#13485) * Bump default 'additional_trie_layers' to two The default here only works for extremely small runtimes, which have no more than 16 storage prefices. This is changed to a "sane" default of 2, which is save for runtimes with up to 4096 storage prefices (eg StorageValue). Signed-off-by: Oliver Tale-Yazdi <[email protected]> * Update tests and test weights Signed-off-by: Oliver Tale-Yazdi <[email protected]> * Fix PoV weights Signed-off-by: Oliver Tale-Yazdi <[email protected]> * ".git/.scripts/commands/bench/bench.sh" pallet dev pallet_balances * ".git/.scripts/commands/bench/bench.sh" pallet dev pallet_message_queue * ".git/.scripts/commands/bench/bench.sh" pallet dev pallet_glutton * ".git/.scripts/commands/bench/bench.sh" pallet dev pallet_glutton * Fix sanity check >0 would also do as a check, but let's try this. Signed-off-by: Oliver Tale-Yazdi <[email protected]> --------- Signed-off-by: Oliver Tale-Yazdi <[email protected]> Co-authored-by: command-bot <> * Move BEEFY code to consensus (#13484) * Move beefy primitives to consensus dir * Move beefy gadget to client consensus folder * Rename beefy crates * chore: move genesis block builder to chain-spec crate. (#13427) * chore: move genesis block builder to block builder crate. * add missing file * chore: move genesis block builder to sc-chain-spec * Update client/chain-spec/src/genesis.rs Co-authored-by: Bastian Köcher <[email protected]> * Update test-utils/runtime/src/genesismap.rs Co-authored-by: Bastian Köcher <[email protected]> * Update test-utils/runtime/client/src/lib.rs * fix warnings * fix warnings --------- Co-authored-by: Bastian Köcher <[email protected]> * Speed up storage iteration from within the runtime (#13479) * Speed up storage iteration from within the runtime * Move the cached iterator into an `Option` * Use `RefCell` in no_std * Simplify the code slightly * Use `Option::replace` * Update doc comment for `next_storage_key_slow` * Make unbounded channels size warning exact (part 1) (#13490) * Replace `futures-channel` with `async-channel` in `out_events` * Apply suggestions from code review Co-authored-by: Koute <[email protected]> * Also print the backtrace of `send()` call * Switch from `backtrace` crate to `std::backtrace` * Remove outdated `backtrace` dependency * Remove `backtrace` from `Cargo.lock` --------- Co-authored-by: Koute <[email protected]> * Removal of Prometheus alerting rules deployment in cloud-infra (#13499) * sp-consensus: remove unused error variants (#13495) * Expose `ChargedAmount` (#13488) * Expose `ChargedAmount` * Fix imports * sc-consensus-beefy: fix metrics: use correct names (#13494) Signed-off-by: acatangiu <[email protected]> * clippy fix * removes NominationsQuotaExceeded event * Update frame/staking/src/lib.rs Co-authored-by: Ross Bulat <[email protected]> * adds back the npos_max_iter * remove duplicate imports added after merge * fmt * Adds comment in public struct; Refactors CountBound and SizeCount to struct * addresses various pr comments * PR comment reviews * Fixes on-chain election bounds and related code * EPM checks the size of the voter list returned by the data provider * cosmetic changes * updates e2e tests mock * Adds more tests for size tracker and refactors code * Adds back only_iterates_max_2_times_max_allowed_len test * Refactor * removes unecessary dependency * empty commit -- restart all stuck CI jobs * restarts ci jobs * Renames ElectionBounds -> Bounds in benchmarking mocks et al * updates mocks * Update frame/election-provider-support/src/lib.rs Co-authored-by: Kian Paimani <[email protected]> * Update frame/staking/src/pallet/impls.rs Co-authored-by: Kian Paimani <[email protected]> * Update frame/election-provider-support/src/lib.rs Co-authored-by: Kian Paimani <[email protected]> * Update frame/staking/src/tests.rs Co-authored-by: Kian Paimani <[email protected]> * more checks in api_nominations_quota in tests * Improves docs * fixes e2e tests * Uses size_hint rather than mem::size_of in size tracker; Refactor size tracker to own module * nits from reviews * Refactors bounds to own module; improves docs * More tests and docs * fixes docs * Fixes benchmarks * Fixes rust docs * fixes bags-list remote-ext-tests * Simplify bound checks in create_snapshot_external * Adds target size check in get_npos_targets * ".git/.scripts/commands/fmt/fmt.sh" * restart ci * rust doc fixes and cosmetic nits * rollback upgrade on parity-scale-codec version (unecessary) * reset cargo lock, no need to update it --------- Signed-off-by: Oliver Tale-Yazdi <[email protected]> Signed-off-by: acatangiu <[email protected]> Co-authored-by: command-bot <> Co-authored-by: Oliver Tale-Yazdi <[email protected]> Co-authored-by: Davide Galassi <[email protected]> Co-authored-by: yjh <[email protected]> Co-authored-by: Bastian Köcher <[email protected]> Co-authored-by: Koute <[email protected]> Co-authored-by: Dmitry Markin <[email protected]> Co-authored-by: Anthony Lazam <[email protected]> Co-authored-by: André Silva <[email protected]> Co-authored-by: Piotr Mikołajczyk <[email protected]> Co-authored-by: Adrian Catangiu <[email protected]> Co-authored-by: Ross Bulat <[email protected]> Co-authored-by: Kian Paimani <[email protected]>

yjhmelody added 2 commits February 21, 2023 14:46

chore: move genesis block builder to block builder crate.

b8a75c4

add missing file

e065861

bkchr approved these changes Feb 23, 2023

View reviewed changes

bkchr added B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit A0-pleasereview labels Feb 23, 2023

bkchr requested a review from a team February 23, 2023 09:44

dmitry-markin reviewed Feb 23, 2023

View reviewed changes

client/block-builder/src/lib.rs Outdated Show resolved Hide resolved

koute reviewed Feb 23, 2023

View reviewed changes

bkchr suggested changes Feb 23, 2023

View reviewed changes

chore: move genesis block builder to sc-chain-spec

9ec6101

Merge branch 'master' into chore-move-genesis-builder

38ef20d

yjhmelody changed the title ~~chore: move genesis block builder to block builder crate.~~ chore: move genesis block builder to chain-spec crate. Feb 24, 2023

bkchr approved these changes Feb 24, 2023

View reviewed changes

client/chain-spec/src/genesis.rs Outdated Show resolved Hide resolved

test-utils/runtime/client/src/lib.rs Outdated Show resolved Hide resolved

test-utils/runtime/src/genesismap.rs Outdated Show resolved Hide resolved

yjhmelody and others added 2 commits February 24, 2023 23:10

Update client/chain-spec/src/genesis.rs

14a2d5e

Co-authored-by: Bastian Köcher <[email protected]>

Update test-utils/runtime/src/genesismap.rs

e3ad634

Co-authored-by: Bastian Köcher <[email protected]>

dmitry-markin approved these changes Feb 24, 2023

View reviewed changes

Update test-utils/runtime/client/src/lib.rs

80f85cb

melekes approved these changes Feb 25, 2023

View reviewed changes

fix warnings

00e4614

bkchr approved these changes Feb 27, 2023

View reviewed changes

fix warnings

0abc61d

bkchr merged commit ad53996 into paritytech:master Feb 28, 2023

nazar-pc mentioned this pull request Apr 2, 2023

Update Substrate autonomys/subspace#1347

Merged

1 task

kiltbot mentioned this pull request Apr 3, 2023

3️⃣ [AUTOMATIC] Update Polkadot dependencies from 0.9.39 to 0.9.40 KILTprotocol/kilt-node#496

Closed

kacperzuk-neti mentioned this pull request Jun 23, 2023

Polkadot v0.9.43 liberland/liberland_substrate#295

Merged

15 tasks

dmitrylavrenov mentioned this pull request Nov 28, 2023

Tracking issue to bump substrate related deps to polkadot-v0.9.40 humanode-network/humanode#839

Closed

46 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chore: move genesis block builder to chain-spec crate. #13427

chore: move genesis block builder to chain-spec crate. #13427

yjhmelody commented Feb 21, 2023 •

edited

Loading

bkchr commented Feb 22, 2023

yjhmelody commented Feb 23, 2023 •

edited

Loading

koute Feb 23, 2023

bkchr left a comment

yjhmelody commented Feb 24, 2023 •

edited

Loading

yjhmelody commented Feb 24, 2023

bkchr left a comment

bkchr commented Feb 24, 2023

yjhmelody commented Feb 24, 2023

melekes left a comment

bkchr commented Feb 25, 2023

bkchr commented Feb 27, 2023

yjhmelody commented Feb 28, 2023

bkchr commented Feb 28, 2023

chore: move genesis block builder to chain-spec crate. #13427

chore: move genesis block builder to chain-spec crate. #13427

Conversation

yjhmelody commented Feb 21, 2023 • edited Loading

bkchr commented Feb 22, 2023

yjhmelody commented Feb 23, 2023 • edited Loading

koute Feb 23, 2023

Choose a reason for hiding this comment

bkchr left a comment

Choose a reason for hiding this comment

yjhmelody commented Feb 24, 2023 • edited Loading

yjhmelody commented Feb 24, 2023

bkchr left a comment

Choose a reason for hiding this comment

bkchr commented Feb 24, 2023

yjhmelody commented Feb 24, 2023

melekes left a comment

Choose a reason for hiding this comment

bkchr commented Feb 25, 2023

bkchr commented Feb 27, 2023

yjhmelody commented Feb 28, 2023

bkchr commented Feb 28, 2023

yjhmelody commented Feb 21, 2023 •

edited

Loading

yjhmelody commented Feb 23, 2023 •

edited

Loading

yjhmelody commented Feb 24, 2023 •

edited

Loading