Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

once_cell in std from 1.70 #14402

Merged
merged 3 commits into from
Jun 24, 2023
Merged

once_cell in std from 1.70 #14402

merged 3 commits into from
Jun 24, 2023

Conversation

gilescope
Copy link
Contributor

While Lazy is not yet stable we can reduce our dependencies a bit.

Depends on #14399 being merged.

@gilescope gilescope added A0-please_review Pull request needs code review. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit labels Jun 16, 2023
@gilescope gilescope requested review from a team June 16, 2023 11:03
@gilescope gilescope requested a review from koute as a code owner June 16, 2023 11:03
@koute
Copy link
Contributor

koute commented Jun 16, 2023

Looks like the CI images have to be updated to include Rust 1.70.

@sam0x17
Copy link
Contributor

sam0x17 commented Jun 16, 2023

Looks like the CI images have to be updated to include Rust 1.70.

Indeed but according to CI team they also can't be until the next version so looks like this will have to wait: https://github.com/paritytech/ci_cd/issues/816#issuecomment-1592952569

@altaua
Copy link
Contributor

altaua commented Jun 16, 2023

Looks like the CI images have to be updated to include Rust 1.70.

Indeed but according to CI team they also can't be until the next version so looks like this will have to wait: paritytech/ci_cd#816 (comment)

Nah, I have worked around that issue in paritytech/polkadot#7386; there are a few other blockers before I can get 1.70 out but it should be doable early next week.

lexnv
lexnv approved these changes Jun 20, 2023
View reviewed changes
Copy link
Contributor

@lexnv lexnv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I think this is ready for merge, now that CI is up to date to 1.70 👍

@sam0x17
Copy link
Contributor

sam0x17 commented Jun 21, 2023

bot rebase

@paritytech-processbot
Copy link

Rebased

@paritytech-cicd-pr
Copy link

The CI pipeline was cancelled due to failure one of the required jobs.
Job name: cargo-check-each-crate-macos
Logs: https://gitlab.parity.io/parity/mirrors/substrate/-/jobs/3051557

@gilescope
Copy link
Contributor Author

https://gitlab.parity.io/parity/mirrors/substrate/-/jobs/3051557 - looks like one of the CI jobs is still using an old rust version.

@altaua
Copy link
Contributor

altaua commented Jun 22, 2023

https://gitlab.parity.io/parity/mirrors/substrate/-/jobs/3051557 - looks like one of the CI jobs is still using an old rust version.

Yep, sorry about that! I forgot to update the rust version on our new mac runners. Fixed.

@gilescope
Copy link
Contributor Author

bot merge

@paritytech-processbot paritytech-processbot bot merged commit 68fe1ef into master Jun 24, 2023
@paritytech-processbot paritytech-processbot bot deleted the giles-reduce-once_cell-use branch June 24, 2023 06:45
nathanwhit pushed a commit to nathanwhit/substrate that referenced this pull request Jul 19, 2023
@gilescope @nathanwhit
once_cell in std from 1.70 (paritytech#14402)
de6878d 
* once_cell now stable

* cargo fmt

---------

Co-authored-by: parity-processbot <>
@jasl jasl mentioned this pull request Aug 21, 2023
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lexnv lexnv lexnv approved these changes

@bkchr bkchr bkchr approved these changes

@sam0x17 sam0x17 sam0x17 approved these changes

@koute koute koute approved these changes

Assignees
No one assigned
Labels
A0-please_review Pull request needs code review. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@gilescope @koute @sam0x17 @altaua @paritytech-cicd-pr @bkchr @lexnv