Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

Remove deprecated old weight items #14706

Merged
merged 3 commits into from
Aug 9, 2023
Merged

Remove deprecated old weight items #14706

merged 3 commits into from
Aug 9, 2023

Conversation

Doordashcon
Copy link
Contributor

@Doordashcon Doordashcon commented Aug 3, 2023 •
edited by juangirini
Loading

@Doordashcon Doordashcon requested review from a team August 3, 2023 20:18
@juangirini juangirini added A0-please_review Pull request needs code review. C1-low PR touches the given topic and has a low impact on builders. B1-note_worthy Changes should be noted in the release notes T1-runtime This PR/Issue is related to the topic “runtime”. labels Aug 4, 2023
@juangirini juangirini changed the title Deprecate old weight items Remove deprecated old weight items Aug 4, 2023
@juangirini juangirini added the D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit label Aug 4, 2023
@juangirini
Copy link
Contributor

bot fmt

@command-bot
Copy link

command-bot bot commented Aug 4, 2023 •
edited
Loading

@juangirini https://gitlab.parity.io/parity/mirrors/substrate/-/jobs/3331206 was started for your command "$PIPELINE_SCRIPTS_DIR/commands/fmt/fmt.sh". Check out https://gitlab.parity.io/parity/mirrors/substrate/-/pipelines?page=1&scope=all&username=group_605_bot to know what else is being executed currently.

Comment bot cancel 5-d6722c6b-e89b-4235-bf12-f2d6574645b9 to cancel this command or bot cancel to cancel all commands in this pull request.

@command-bot
Copy link

command-bot bot commented Aug 4, 2023

@juangirini Command "$PIPELINE_SCRIPTS_DIR/commands/fmt/fmt.sh" has finished. Result: https://gitlab.parity.io/parity/mirrors/substrate/-/jobs/3331206 has finished. If any artifacts were generated, you can download them from https://gitlab.parity.io/parity/mirrors/substrate/-/jobs/3331206/artifacts/download.

@juangirini juangirini mentioned this pull request Aug 24, 2023
Closed
@juangirini juangirini requested a review from a team August 9, 2023 07:57
@juangirini juangirini mentioned this pull request Aug 9, 2023
Open
ggwpez
ggwpez approved these changes Aug 9, 2023
View reviewed changes
Copy link
Member

@ggwpez ggwpez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@ggwpez
Copy link
Member

ggwpez commented Aug 9, 2023

bot merge

@paritytech-processbot paritytech-processbot bot merged commit ece92d6 into paritytech:master Aug 9, 2023
8 checks passed
@crystalin crystalin mentioned this pull request Oct 20, 2023
Closed
@JesseAbram JesseAbram mentioned this pull request Oct 26, 2023
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@juangirini juangirini juangirini approved these changes

@ggwpez ggwpez ggwpez approved these changes

@KiChjang KiChjang Awaiting requested review from KiChjang

Assignees
No one assigned
Labels
A0-please_review Pull request needs code review. B1-note_worthy Changes should be noted in the release notes C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit T1-runtime This PR/Issue is related to the topic “runtime”.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Doordashcon @juangirini @ggwpez