This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
Format and Sort features in Cargo.toml files
#14803
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Oliver Tale-Yazdi <[email protected]>
Signed-off-by: Oliver Tale-Yazdi <[email protected]>
Signed-off-by: Oliver Tale-Yazdi <[email protected]>
This reverts commit b2b1099.
ggwpez
requested review from
athei,
acatangiu,
sorpaas,
andresilva,
jsidorenko and
cheme
as code owners
ggwpez
added
A0-please_review
Signed-off-by: Oliver Tale-Yazdi <[email protected]>
bkchr
approved these changes
Aug 21, 2023
scripts/ci/gitlab/pipeline/test.yml
Outdated
| - .test-refs | ||
| script: | ||
| - cargo install zepter --locked --version 0.9.2 -q -f --no-default-features && zepter --version | ||
| - zepter format features --workspace --fix |
There was a problem hiding this comment.
The tool should be documented in the contribution guides or similar and how to use it
There was a problem hiding this comment.
Better to add a bash script and run it in ci for local dev?
There was a problem hiding this comment.
I added some docs to the STYLE_GUIDE and mention it in the CI output.
WDYM? Running zepter format features (the --workspace and --fix flag are implicit now) is not much longer than invoking a bash script.
KiChjang
reviewed
Aug 21, 2023
liamaharon
approved these changes
Aug 22, 2023
Signed-off-by: Oliver Tale-Yazdi <[email protected]>
Signed-off-by: Oliver Tale-Yazdi <[email protected]>
Signed-off-by: Oliver Tale-Yazdi <[email protected]>
Signed-off-by: Oliver Tale-Yazdi <[email protected]>
Signed-off-by: Oliver Tale-Yazdi <[email protected]>
altaua
approved these changes
Aug 23, 2023
Signed-off-by: Oliver Tale-Yazdi <[email protected]>
Signed-off-by: Oliver Tale-Yazdi <[email protected]>
alvicsam
approved these changes
Aug 23, 2023
|
bot merge |
|
Waiting for commit status. |
ggwpez
added a commit
to ggwpez/zepter
that referenced
this pull request
Aug 23, 2023
paritytech/substrate#14803 should ensure that Substrate master stays formatted. We can therefore check this here already to ensure to not break it. Signed-off-by: Oliver Tale-Yazdi <[email protected]>
ggwpez
added a commit
to ggwpez/zepter
that referenced
this pull request
Aug 23, 2023
paritytech/substrate#14803 should ensure that Substrate master stays formatted. We can therefore check this here already to ensure to not break it. Signed-off-by: Oliver Tale-Yazdi <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
Cargo.tomlfiles.Cargo.tomls are formatted.Its fine if we dont merge this before the monorepo; this MR is mostly to gather feedback on the formatting.
Are you OK with the canonical format that this introduces? Eventually we should add it to
bot fmt.My only point would be that the
defaultfeature looks slightly weird, give that it normally just contains one item. On the other hand, this creates a uniform formatting for all features... WDYT?I asserted locally that this does not alter the sha256 of the kitchensink runtime.
The CI prints a diff on error to make debugging easier: