This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
PoC-1 backwards compatibility #281
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gavofyork
approved these changes
Jul 5, 2018
gavofyork
added
A8-looksgood
and removed
A0-please_review
|
doesn't work for me... https://gist.github.com/gavofyork/be4f5d094b615f4d007099a4db4bdef7 |
|
@gavofyork could you try with |
rphmeier
reviewed
Jul 5, 2018
substrate/network/src/message.rs
Outdated
| #[derive(Debug, PartialEq, Eq, Clone, Serialize, Deserialize)] | ||
| #[serde(untagged)] | ||
| // TODO: remove this after poc-2 | ||
| /// Justification back compat |
There was a problem hiding this comment.
nit: annotations under docs
JoshOrndorff
added a commit
to moonbeam-foundation/substrate
that referenced
this pull request
Apr 21, 2021
liuchengxu
pushed a commit
to chainx-org/substrate
that referenced
this pull request
Aug 23, 2021
* Update xbridge-related fees (paritytech#281) * Adjust penalty * modify genesis config * rename treasuryaddr to counciladdr * Readd token discount and to channel logic (paritytech#284) * Readd token discount and channel share logic * Refactor a bit * Modify btc-fee (paritytech#285) Add maximum withdraw amount check * let tokenname verify more char * spot safe check (paritytech#286) * Revert "spot safe check (paritytech#286)" (paritytech#291) This reverts commit 8092ba50abf1d5646000342d9229b1d81e4b025d. * Feature/trustee rpc (paritytech#293) * Add 'chainx_getTrusteeAddress' rpc * Delete dead code * change verifyaddr rpc return true/false * Fix merge conflicts * token discount (paritytech#313) * token discount * adjust * fix bug * Fix token_discount in genesis_config * Rebuild wasm and replace wasm in cli/src/chainx_runtime_wasm.compact.wasm
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.