This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
More timely block import notifications #306
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pepyakin
reviewed
Jul 12, 2018
substrate/telemetry/src/lib.rs
Outdated
| @@ -58,7 +58,7 @@ pub fn init_telemetry(config: TelemetryConfig) -> slog_scope::GlobalLoggerGuard | |||
| first_time: true, // ensures that on_connect will be called. | |||
| } | |||
| ).fuse() | |||
| ).build().fuse(), o!() | |||
| ).chan_size(262144).overflow_strategy(slog_async::OverflowStrategy::DropAndReport).build().fuse(), o!() | |||
There was a problem hiding this comment.
What does this number mean?
There was a problem hiding this comment.
256kb of buffer length to store info in before dropping entries, I suppose, @pepyakin ?
There was a problem hiding this comment.
Yeah, sure. Can we leave a comment? Just a lil bit wary about magic numbers.
gnunicorn
approved these changes
Jul 12, 2018
substrate/client/src/client.rs
Outdated
| @@ -335,6 +335,7 @@ impl<B, E, Block> Client<B, E, Block> where | |||
|
|
|||
| let is_new_best = header.number() == &(self.backend.blockchain().info()?.best_number + One::one()); | |||
| trace!("Imported {}, (#{}), best={}, origin={:?}", hash, header.number(), is_new_best, origin); | |||
| telemetry!("block.import"; "height" => { let n: u64 = header.number().as_(); n }, "best" => ?hash, "is_new_best" => is_new_best, "origin" => ?origin); | |||
There was a problem hiding this comment.
could we please wrap this 158char line ;) ?
There was a problem hiding this comment.
This should be called after import_lock is released in import_block.
arkpar
added
A5-grumble
and removed
A0-please_review
gavofyork
added
A0-please_review
|
Requesting voice in the Riot Technical channel: id: pomomoh |
tomusdrw
approved these changes
Jul 13, 2018
substrate/client/src/client.rs
Outdated
| @@ -300,6 +300,11 @@ impl<B, E, Block> Client<B, E, Block> where | |||
| *self.importing_block.write() = Some(hash); | |||
| let result = self.execute_and_import_block(origin, hash, header, justification, body); | |||
| *self.importing_block.write() = None; | |||
| telemetry!("block.import"; | |||
| "height" => { let n: u64 = header.number().as_(); n }, | |||
There was a problem hiding this comment.
shouldn't:
"height" => header.number().as_::<u64>(),
work?
There was a problem hiding this comment.
no - as_ doesn't take a generic param: the trait does.
gavofyork
added
A8-looksgood
and removed
A0-please_review
lamafab
pushed a commit
to lamafab/substrate
that referenced
this pull request
Jun 16, 2020
JoshOrndorff
pushed a commit
to moonbeam-foundation/substrate
that referenced
this pull request
Apr 21, 2021
* done * bump spec * fix types
liuchengxu
added a commit
to chainx-org/substrate
that referenced
this pull request
Aug 23, 2021
* Only accept these intentions with a related TrusteeEntity - Fixes paritytech#292 - also change MAX trustee intentions from 16 to 15 * Skip set_validators when the validator set stays the same Fixes paritytech#295 * Enforce these punished to be inactive on new session instead of new era Fixes paritytech#294 * Make items in the punish list unique - Fixes paritytech#307 - Also refactor a bit in genesis_config.rs - Return if the count of candidates less than minimal validator count on enforce_inactive. * Store trustee_count and minimum_trustee_count in Runtime - also tweak some parameters. * Add new event: EnforceValidatorsInactive * Rebuild wasm * Build wasm
liuchengxu
pushed a commit
to chainx-org/substrate
that referenced
this pull request
Aug 23, 2021
Signed-off-by: koushiro <[email protected]>
liuchengxu
pushed a commit
to autonomys/substrate
that referenced
this pull request
Jun 3, 2022
macOS 12 signing fix
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.