Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

Update soketto to version 0.2.3 #3448

Merged
merged 1 commit into from
Aug 21, 2019
Merged

Conversation

twittner
Copy link
Contributor

This version fixes an issue with lifetime elision which causes compilation to fail on recent rustc versions (e.g. 1.39.0-nightly (bea0372a1 2019-08-20)).

See paritytech/soketto#1 for more information.

This version fixes an issue with lifetime elision which causes
compilation to fail on recent rustc versions (e.g. 1.39.0-nightly
(bea0372a1 2019-08-20)).

See paritytech/soketto#1 for more information.
@twittner twittner added the A2-insubstantial Pull request requires no code review (e.g., a sub-repository hash update). label Aug 21, 2019
@@ -5724,7 +5724,7 @@ name = "twox-hash"
version = "1.4.2"
source = "registry+https://github.com/rust-lang/crates.io-index"
dependencies = [
"rand 0.6.5 (registry+https://github.com/rust-lang/crates.io-index)",
"rand 0.3.23 (registry+https://github.com/rust-lang/crates.io-index)",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure why this changed.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really weird downgrade.

@@ -5724,7 +5724,7 @@ name = "twox-hash"
version = "1.4.2"
source = "registry+https://github.com/rust-lang/crates.io-index"
dependencies = [
"rand 0.6.5 (registry+https://github.com/rust-lang/crates.io-index)",
"rand 0.3.23 (registry+https://github.com/rust-lang/crates.io-index)",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really weird downgrade.

@twittner
Copy link
Contributor Author

About the rand downgrade for the twox-hash dependency -- I do not know what is causing this either. It is what cargo update -p soketto produced. But we can manually edit Cargo.lock to retain rand 0.6.5 for twox-hash if that is preferred. FWIW it does compile on my machine.

@gavofyork gavofyork merged commit 84f6e55 into paritytech:master Aug 21, 2019
@twittner twittner deleted the update-soketto branch January 22, 2020 16:07
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A2-insubstantial Pull request requires no code review (e.g., a sub-repository hash update).
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants