This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
Fix reimporting transactions from retracted blocks. #4250
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Most of the chains will not really use a runtime-type of
UncheckedExtrinsicfor their in-block extrinsic type, but rather the node will only know aboutOpaqueExtrinsictype.This type implements
Extrinsictrait, howeveris_signedalways returnsNone.The fix makes sure we re-import transactions even though
is_signedisNone, and we also tone-down the warning level (which seemed to be a reason to add that check in the first place).Additionally some small changes to add logging and an attempt to clean the naming of methods (
remove_invalidvsremove_subtree). This is an intro to a bigger change which would be periodic revalidation of transactions in the pool.Should fix #4107