This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

Do not issue empty remote read request + fix rr-related trace on full node #4619

Merged

svyatonik merged 1 commit into master from fix_empty_remote_read_request

Jan 14, 2020

Contributor

svyatonik commented Jan 14, 2020

Fixes two related issues:

there's no need to issue empty RemoteRead && RemoteReadChild requests from light node and it turns current UI (at https://polkadot.js.org/apps/#/) does this;
I've recently introduced invalid trace!() call in network (when we moved to single-key-in-remote-request to multiple-keys-in-single-remote-request) which leads to panic when invalid request is received over network :(


          fixed panic on empty remote read request

6bbc996

svyatonik added A0-please_review M4-core labels

svyatonik requested a review from tomusdrw as a code owner

January 14, 2020 14:22

tomusdrw approved these changes

View reviewed changes

Contributor

tomusdrw left a comment

Looks good to me, I don't know that much about networking though, but disconnecting + reporting seems reasonable too.

tomusdrw added A8-looksgood and removed A0-please_review labels

svyatonik merged commit 45995b4 into master

svyatonik deleted the fix_empty_remote_read_request branch

January 14, 2020 15:49

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet