This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
Refactor the balances module #4649
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gavofyork
added
the
A3-in_progress
xlc
reviewed
Jan 22, 2020
Co-Authored-By: Xiliang Chen <[email protected]>
Co-Authored-By: Xiliang Chen <[email protected]>
…refactor-balances
xlc
reviewed
Jan 27, 2020
gavofyork
added
the
U1-asap
|
@shawntabrizi any further comments? |
shawntabrizi
approved these changes
Jan 31, 2020
|
not sure we really can; re: execution-time it's not a big deal - it'll just be a long block. memory usage should be fine in principle, however if there's some issue with memory leakage (like that you found), then it could be a problem. i'd like to know what's going on with that before upgrading. |
|
ok - obvious way to test is to dump balances state, spin up a local testnet with it as genesis and then execute with wasm. |
|
Tested it on a dev chain, and can confirm it works fine in wasm. (Actually it's surprisingly fast migrating ~7k accounts) |
This was referenced Feb 1, 2020
20 tasks
|
This pull request has been mentioned on Polkadot Forum. There might be relevant details there: https://forum.polkadot.network/t/moving-frame-out-of-substrate/907/1 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #4613
Note that this "cheats" slightly and coalesces
WithdrawReasonswithin balances to just two categories: TransactionPayment (Fees) and everything else (Misc). That allows an aggregate to be stored and avoids lock-list traversals in all balance operations without bloating the account storage item too much. It does mean that locking an account forTransfersnow also locks it forReserves as well, but it's questionable whether they should ever really have been separate in the first place. I leftWithdrawReasonsas it is since I couldn't see any reason to dumb down the public API just because one implementation happens to implement it in a conservative way.TODO: