Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

client/finality-grandpa/communication: Add doc comment for PeerReport #4684

Merged
merged 1 commit into from
Jan 20, 2020

Conversation

mxinden
Copy link
Contributor

@mxinden mxinden commented Jan 20, 2020

Applying review suggestion from https://github.com/paritytech/substrate/pull/4661/files#r368046058.

@rphmeier I think the members of the struct are self-explanatory. Let me know if you still want them documented.

@rphmeier
Copy link
Contributor

I think the members of the struct are self-explanatory. Let me know if you still want them documented.

I won't push for it, but I have a preference for documenting all public items because the auto-generated docs look better and it's a good habit to keep.

@rphmeier rphmeier added A8-looksgood and removed A0-please_review Pull request needs code review. labels Jan 20, 2020
@gavofyork gavofyork merged commit a083572 into paritytech:master Jan 20, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants