Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

Remove dependency assert_cmd #5480

Closed
wants to merge 2 commits into from
Closed

Remove dependency assert_cmd #5480

wants to merge 2 commits into from

Conversation

cecton
Copy link
Contributor

@cecton cecton commented Apr 1, 2020

We don't use many features of this dependency and it is causing problems on
the CI at the moment.

Related to: assert-rs/assert_cmd#99 assert-rs/assert_cmd#98 assert-rs/assert_cmd#97

Forked at: d477017
Parent branch: origin/master
We don't use many features of this dependency and it is causing problems on
the CI at the moment.
@parity-cla-bot
Copy link

It looks like @cecton signed our Contributor License Agreement. 👍

Many thanks,

Parity Technologies CLA Bot

@cecton cecton self-assigned this Apr 1, 2020
@cecton cecton requested a review from shawntabrizi April 1, 2020 09:48
Copy link
Member

@shawntabrizi shawntabrizi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems sensible, but probably should get a second review if this is a good practice.

@cecton cecton requested review from bkchr and gnunicorn April 1, 2020 09:52
@cecton
Copy link
Contributor Author

cecton commented Apr 1, 2020

It would be better to fix the real issue but it's faster that way

@bkchr
Copy link
Member

bkchr commented Apr 1, 2020

That will not solve any problem!

This only materializes with assert_cmd because the list of deps is probably sorted and starts with assert_cmd. Any other dependency will very likely also fail.

Thus, I will close this.

@bkchr bkchr closed this Apr 1, 2020
@bkchr bkchr deleted the cecton-remove-assert-cmd branch April 1, 2020 09:54
@cecton
Copy link
Contributor Author

cecton commented Apr 1, 2020

@bkchr so this won't solve the problem either? assert-rs/assert_cmd#99

@bkchr
Copy link
Member

bkchr commented Apr 1, 2020

Can you reproduce the bug locally? I assume not. As @TriplEight already found out, it is related to cache corruption: rust-lang/cargo#4007 (comment)

The problem is always solved by deleting the cache, this is no bug in assert_cmd.

@cecton
Copy link
Contributor Author

cecton commented Apr 1, 2020

Ok thanks I closed the ticket

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants