This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
Remove requirement of function indices for decl_module! #666
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gavofyork
approved these changes
Sep 5, 2018
bkchr
force-pushed
the
decl_module_do_not_require_function_index
branch
from
19b90d0
to
5cee050
Compare
bkchr
force-pushed
the
decl_module_do_not_require_function_index
branch
from
5cee050
to
db21e31
Compare
dvdplm
added a commit
that referenced
this pull request
Sep 8, 2018
…rs-generic-over-hasher-and-rlpcodec * origin/master: Fixed sync stalling when import queue is full (#691) New extrinsic dispatch model (#678) remove parachain's Cargo.lock (#682) Implement json metadata for outer events (#672) Improvements to the Kademlia system (#688) Use BufReader and BufWriter (#684) Switch to using parity/rust:substrate which has rust nightly-2018-08-31 (#686) Update to latest libp2p (#673) Implement storage json metadata (#670) impl MaybeEmpty for H256 and u64 (aka AccountId in prod/tests) (#665) Speedup compilation (#671) Remove requirement of function indices for decl_module! (#666) DigestItem trait (v2) (#650)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this patch, the
decl_module!macro does not require function indices.This implementation has two drawbacks:
"0 + 1 + 1"for the second index. Its not that huge problem, as the sum should be easily implementable in javascript.matchtoifs. This could have some impact on the performance.