This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
Add BoundedBTreeMap to frame_support::storage
#8745
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
coriolinus
added
A0-please_review
20 tasks
|
Initial review looks good 👍 |
kianenigma
reviewed
May 6, 2021
| } | ||
| } | ||
|
|
||
| impl<K, V, S> Default for BoundedBTreeMap<K, V, S> |
There was a problem hiding this comment.
Can't you use DefaultNoBound and similar?
There was a problem hiding this comment.
No, unfortunately; I didn't look into the root cause in much detail, but when I attempted it, it seemed that that macro doesn't produce appropriate bounds for this case; it just generated a bunch of compile errors. The manual implementation was simple enough anyway.
kianenigma
reviewed
May 6, 2021
kianenigma
reviewed
May 6, 2021
kianenigma
approved these changes
May 6, 2021
shawntabrizi
approved these changes
May 6, 2021
|
bot merge |
|
Trying merge. |
ghost
merged commit 
jakoblell
added
D1-audited 👍
nazar-pc
pushed a commit
to autonomys/substrate
that referenced
this pull request
Aug 8, 2021
* Add `BoundedBTreeMap` to `frame_support::storage` Part of paritytech#8719. * max_encoded_len will never encode length > bound * requiring users to maintain an unchecked invariant is unsafe * only impl debug when std * add some marker traits * add tests
This pull request was closed.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #8719.
Tests
forthcomingimplemented.