Support loading keys from Polkadot-JS accounts. #1661
Conversation
|
User @ethernomad, please sign the CLA here. |
Co-authored-by: Niklas Adolfsson <[email protected]>
signer/Cargo.toml
Outdated
| @@ -35,6 +40,9 @@ sr25519 = ["schnorrkel"] | |||
| ecdsa = ["secp256k1"] | |||
| unstable-eth = ["keccak-hash", "ecdsa", "secp256k1", "bip32"] | |||
|
|
|||
| # Enable support for loading key pairs from polkadot-js json. | |||
| json = ["std", "subxt", "sr25519", "base64", "scrypt", "crypto_secretbox", "serde", "serde_json"] | |||
There was a problem hiding this comment.
Do we really need std enabled for this json feature?
There was a problem hiding this comment.
This is necessary for the following command to succeed:
cargo test --no-default-features -F polkadot-js-compat
There was a problem hiding this comment.
Do you know why this is necessary for that command to succeed? I had another look over and it's not a huge deal but would be nice not to need the std feature :)
I get a 404 when I try to sign the CLA - anyone know where I can report this?
|
Co-authored-by: James Wilson <[email protected]>
|
This pull request is ready to review again. |
|
The cla bot still crashes when I try to sign it. |
It seems to have been accepted anyways by the looks of things :) |
|
Modulo a couple of tiny dependency related nits I'm happy with this! Thankyou @ethernomad! |
|
@ethernomad re. CLA bot - you've already signed it, so all good
it's just bad user-experience in its logic, when you try to sign once-again it gives 404 O_o which was unexpected for me to see too :D |
A common way to manage keys for Substrate accounts is to use the Polkadot JS browser extension. Accounts in the extension can be exported to an encrypted JSON file.
It would be very useful for subxt to support loading keys from these files. Both long running services and interactive programs built with subxt would be able to load accounts exported from the browser extension.
The JSON schema is described here:
https://github.com/polkadot-js/common/blob/37fa211fdb141d4f6eb32e8f377a4651ed2d9068/packages/keyring/src/types.ts#L67
The password is hashed with Scrypt and then the ciphertext is decrypted with XSalsa20Poly1305.
The implementation in the pull request is very rigid, inline with the JS implementation.
Here is the original issue: #1631