Skip to content
This repository has been archived by the owner on May 21, 2024. It is now read-only.

Backport PRs from main branch #184

Closed
wants to merge 32 commits into from
Closed

Conversation

valentinfernandez1
Copy link
Contributor

It backports the changes introduced to the main branch and updates them to v9.40. The PRs updated are:

The weights of the pallets were re-benchmarked to use Weights V2.


It also fixes Trappist and Stout UnitWeightCost to match the config of the parachain-template.

parameter_types! {
	....
	pub UnitWeightCost: Weight = Weight::from_parts(1_000_000_000, 64 * 1024);
	....
}

@valentinfernandez1 valentinfernandez1 requested review from hbulgarini, stiiifff and kalaninja and removed request for hbulgarini May 22, 2023 15:16
Copy link
Contributor

@stiiifff stiiifff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@valentinfernandez1 This is very difficult to review as-is. Having all PRs mixed up into one means the reviewer has to go back to the original PRs and do a very thorough job of re-examining everything.
My bad, maybe I should have mentioned it in the issue #184.
I would suggest to close it, and restart by opening one separate PR per the original PRs being back-ported. This will be much faster and less error-prone.

In each PR, please specify the original PR number and commit hash e.g.

run tests on CI (#174) (cherry picked from commit d826938)

@valentinfernandez1
Copy link
Contributor Author

You are right, I didn't realized how difficult it was going to be to review so many different changes. I will split them into different PRs to simplify it.

Also it makes more sense this way since more things will need to be backported like #185 and this way it's going to be easier to identify each change.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants