Support for Nacon Pro Compact #229
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Daniel Tobias <[email protected]>
Signed-off-by: Daniel Tobias <[email protected]> Signed-off-by: Jonathan <[email protected]> Signed-off-by: Matt Sturgeon <[email protected]>
Many knockoff brands emulating the XBOX 360 controller do not properly send data unless configured correctly. Examples include the Gamesir G3w and the Fantech GP11 Shooter. Protocol inspection of communication with other operating systems reveals a sequence of control messages that can be used to initialize the controllers sufficiently to send proper data. Some of these controllers only require one and may break with further, some may require all three. This change adds a quirks field that allows specifying these initialization packets. Note that it also removes an unused field from the controller type table. Signed-off-by: Darvin Delgado <[email protected]> Signed-off-by: Vicki Pfau <[email protected]>
only renames, no functional changes - even though some of the packets we send are suspicious. However, I dont have the hardware to verify they are truly superflous.
This allows to turn off the pad without having to release the Xbox (mode) button Signed-off-by: Davide Garberi <[email protected]>
This occurs with MSI GC20 on Ubuntu 22.04.1 LTS. Signed-off-by: Eldad Zack <[email protected]>
Signed-off-by: Josh Cotton <[email protected]>
8BitDo Pro 2 Wired Controller shares the same USB identifier (2dc8:3106) as a different device, so amend name to reflect that and reduce confusion as the user might think the controller was misdetected. I have personally tested it and I can confirm that Pro 2 Wired will also not work in XTYPE_XBOXONE mode (buton presses won't register), therefore XTYPE_XBOX360 remains appropriate. Signed-off-by: Leonardo Brondani Schenkel <[email protected]>
|
please check current master again. probably this is not needed any more |
My 2 controllers have product ids 0x0616 and 0x0618 respectively so I think this PR is still needed for them to work: General (noob) questions regarding the structure of this driver: Does that mean that all vendor and product IDs have to be listed explicitly in the driver for it to work? Would it make sense to make an exception for this driver? Having to list all vendors/products that effectively talk the same protocol seems quite tedious/ineffective. |
|
Hello will this be merged? because i have a similar problem my nacon controller has the id: 3285:0616 currently i have simply changed the xpad kernel module myself, but i would like to use the official version ;) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.