User signup with installationId #1031
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes: #536 Parse.User.signUp actually does a ParseObject.save() at its core which does not send an installationId. This is useful to prevent invalid session token and tests session clean up.
Codecov Report
@@ Coverage Diff @@
## master #1031 +/- ##
==========================================
+ Coverage 92.03% 92.11% +0.08%
==========================================
Files 53 53
Lines 5112 5114 +2
Branches 1141 1142 +1
==========================================
+ Hits 4705 4711 +6
+ Misses 407 403 -4
Continue to review full report at Codecov.
|
davimacedo
approved these changes
Dec 11, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #536
Parse.User.signUp actually does a ParseObject.save() at its core which does not send an installationId.
This is useful to prevent invalid session token and tests session clean up.