-
-
Notifications
You must be signed in to change notification settings - Fork 597
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: Fix TypeScript type correctness test #2134
Conversation
Thanks for opening this pull request!
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## alpha #2134 +/- ##
==========================================
Coverage 100.00% 100.00%
==========================================
Files 61 64 +3
Lines 6186 6325 +139
Branches 1499 1514 +15
==========================================
+ Hits 6186 6325 +139 ☔ View full report in Codecov by Sentry. |
This reverts commit fd3467d.
@mtrezza This is ready for review, I'll fix the linting type issue in another PR. |
🎉 This change has been released in version 5.2.0-alpha.1 |
🎉 This change has been released in version 5.2.0-beta.1 |
🎉 This change has been released in version 5.2.0 |
Pull Request
Issue
npm run test:types
Approach
Convert the following to TypeScript
Added
dom
tolibs
in tsconfig forCannot find name 'URL'.
errorFixed linting issues, for some reason the declaration files d.ts have parsing issues
Tasks