-
-
Notifications
You must be signed in to change notification settings - Fork 597
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
style: Run Prettier for TypeScript declaration files #2142
Conversation
Thanks for opening this pull request!
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## alpha #2142 +/- ##
==========================================
Coverage 100.00% 100.00%
==========================================
Files 61 64 +3
Lines 6186 6371 +185
Branches 1499 1511 +12
==========================================
+ Hits 6186 6371 +185 ☔ View full report in Codecov by Sentry. |
Quite impressive |
🎉 This change has been released in version 5.2.0-alpha.2 |
🎉 This change has been released in version 5.2.0-beta.1 |
🎉 This change has been released in version 5.2.0 |
Pull Request
Issue
TypeScript declaration files
.d.ts
are generated with tabs instead of spaces and other formatting issues. This will causedtslint
to fail. Running Prettier + Lint --fix against these files leaves only type correctness checks and tests.Approach
Converts the following files to TS
Tasks