refactor: Remove OCMock Carthage dependency #1754

dplewis · 2023-10-06T16:10:21Z

New Pull Request Checklist

I am not disclosing a vulnerability.
I am creating this PR in reference to an issue.

Issue Description

Closes: #1747

Approach

Update minimum deployment versions.
Add minimum deployment versions to README
Add SPM caching to CI
Expose ParseFacebookUtils
Install OCMock via SPM
Clean up missing file references

TODOs before merging

Add tests
Add changes to documentation (guides, repository pages, in-code descriptions)

parse-github-assistant · 2023-10-06T16:10:24Z

Thanks for opening this pull request!

🎉 We are excited about your hands-on contribution!

codecov · 2023-10-06T16:23:17Z

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (c4998e6) 11.24% compared to head (137e9a5) 64.40%.

Additional details and impacted files

@@             Coverage Diff             @@
##           master    #1754       +/-   ##
===========================================
+ Coverage   11.24%   64.40%   +53.16%     
===========================================
  Files         195      200        +5     
  Lines       23015    23176      +161     
===========================================
+ Hits         2587    14927    +12340     
+ Misses      20428     8249    -12179

see 141 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

mtrezza · 2023-10-06T19:42:34Z

Removed myself from review since there have been more commits after the request. When this is ready for review please request again from @parse-community/ios-sdk-review

dplewis · 2023-10-06T19:49:29Z

I would but it looks like you aren't a member of @parse-community/ios-sdk-review. Do you get notified?

mtrezza · 2023-10-06T20:49:20Z

You are right; I'm now

Parse/Parse/Resources/Parse-iOS.Info.plist

ParseFacebookUtils/ParseFacebookUtils/Resources/Info-iOS.plist

ParseFacebookUtilsiOS/ParseFacebookUtilsiOS/Resources/Info-iOS.plist

mtrezza

Looks good; is this ready for merge?

dplewis · 2023-10-07T00:21:14Z

Yes

mtrezza

Actually it seems that this is a breaking change, because it is removing watchOS 2 and 3 compatibility, right?

Package.swift is currently at .watchOS(.v2).

possibly breaking change, needs to be re-evaluated

dplewis · 2023-10-07T00:31:55Z

Watch OS 2 and 3 are over 7 years old. Yes this could be a breaking change.

mtrezza · 2023-10-07T00:53:59Z

Is the removal of watchOS 2 and 3 compatibility required to remove the OCMock Carthage dependency?

dplewis · 2023-10-07T01:04:32Z

OCMock minimum version has always been watchOS 4

For reverence

Bolts-Swift is v3
Bolts-Objc is v2
Starscream is v2

dplewis · 2023-10-07T01:26:31Z

@mtrezza If you build this PR you will see dependency 'OCMock' is not used by any target. It's basically a dev dependency.

WatchOS 4 is the minimum support for Xcode 14+

The Xcode 14 release supports on-device debugging in iOS 11 and later, tvOS 11 and later, and watchOS 4 and later. Xcode 14 requires a Mac running macOS Monterey 12.5 or later.

Xcode won't let me choose a target less than WatchOS 4

mtrezza · 2023-10-07T01:42:54Z

So the watchOS bump is unrelated to the removal of OCMock? If that is so, I think it would be better to do that in a separate PR.

dplewis · 2023-10-07T03:11:25Z

@mtrezza Changes have been made. Flaky test causing CI to fail. This is ready to merge no need to restart the CI.

mtrezza · 2023-10-07T08:44:43Z

Do you want to open another PR to bump the deployment target to watchOS 4?

dplewis · 2023-10-07T12:56:32Z

We support Xcode 14+, any developer making a WatchOS app is forced to use WatchOS 4+. 4 > 2 so there will never be an issue. If the Repo was developed specifically for WatchOS then I would do a PR.

mtrezza · 2023-10-08T08:50:09Z

But why did you bump this in the first place then?

dplewis · 2023-10-08T13:09:19Z

I thought I was right at the time. I'm still learning. This project hasn't been worked on in a long time. Maybe I'm still right. I know why this project supports iOS 12 as a minimum do you?

mtrezza · 2023-10-08T14:49:22Z

I've mentioned my concerns about support policy of older versions in #1755. Maybe the discussion should continue there.

dplewis · 2023-10-08T15:32:34Z

Do what you have to, just don't increase the CI build time. Thats the only reason by I'm working on this project right now. I don't work on the parse-server anymore because of the / your policy

mtrezza · 2023-10-08T16:38:52Z

Not sure what you mean by that, but as always please feel free to open an issue in the Parse Server repository if you feel that a policy there is making it difficult for you to contribute.

parseplatformorg · 2024-04-08T14:51:53Z

🎉 This change has been released in version 3.0.0

* commit 'ef9b00de9eeeca7fddfe9439141f5141ff5dac02': (86 commits) chore(release): 3.0.0 [skip ci] ci: Fix release workflow (parse-community#1782) feat: Remove `ParseFacebookUtils` and `ParseTwitterUtils` (parse-community#1779) feat: Add `PFObject.isDataAvailableForKey` to check if data is available for individual key (parse-community#1756) ci: Bump ip from 2.0.0 to 2.0.1 (parse-community#1772) ci: Fix failing CI by pinning bundler version (parse-community#1778) refactor: Remove Carthage dependency (parse-community#1763) refactor: Remove OCMock Carthage dependency (parse-community#1754) ci: Run CI on Xcode 15 and macOS 13 (parse-community#1753) refactor: Update ruby dependencies (parse-community#1752) refactor: Remove framework builder for assets (parse-community#1751) chore(release): 2.7.3 [skip ci] fix: Compilation errors in `ParseLiveQuery` using `Starscream` 4.0.6 (parse-community#1749) docs: Add changelog note about missing assets (parse-community#1750) chore(release): 2.7.2 [skip ci] fix: Compilation errors `Undefined symbol` and `SystemConfiguration not found` on watchOS (parse-community#1748) ci: Remove publishing release assets (parse-community#1745) ci: Fix and build Starter Projects (parse-community#1744) chore(release): 2.7.1 [skip ci] fix: Compilation error on macOS `Undefined symbol: OBJC_CLASS$_PFProductsRequestHandler` (parse-community#1739) ...

refactor: Remove OCMock Carthage Dependency

3d1ad34

fix twitter tests

0ace39a

dplewis requested a review from mtrezza October 6, 2023 17:25

dplewis added 3 commits October 6, 2023 13:20

test spm cache

7268691

fix parse ui duplicate files on two apps with same name

8f65305

Merge branch 'master' into remove-ocmock

6d8c4e9

mtrezza removed their request for review October 6, 2023 19:40

dplewis requested a review from a team October 6, 2023 19:54

mtrezza changed the title ~~refactor: Remove OCMock Carthage Dependency~~ refactor: Remove OCMock Carthage dependency Oct 6, 2023

mtrezza reviewed Oct 6, 2023

View reviewed changes

Parse/Parse/Resources/Parse-iOS.Info.plist Show resolved Hide resolved

ParseFacebookUtils/ParseFacebookUtils/Resources/Info-iOS.plist Show resolved Hide resolved

ParseFacebookUtilsiOS/ParseFacebookUtilsiOS/Resources/Info-iOS.plist Show resolved Hide resolved

dplewis requested a review from a team October 6, 2023 21:48

mtrezza previously approved these changes Oct 7, 2023

View reviewed changes

mtrezza reviewed Oct 7, 2023

View reviewed changes

mtrezza added the state:breaking label Oct 7, 2023

dplewis requested a review from mtrezza October 7, 2023 00:40

dplewis added 2 commits October 6, 2023 20:55

WatchOS v4 to v2

c1f4587

Update ReadME

137e9a5

mtrezza merged commit a87bfb0 into parse-community:master Oct 7, 2023
13 checks passed

dplewis deleted the remove-ocmock branch October 7, 2023 12:53

mtrezza removed the state:breaking label Oct 8, 2023

mtrezza mentioned this pull request Oct 8, 2023

Remove Carthage Dependencies #1747

Closed

14 tasks

parseplatformorg added the state:released Released as stable version label Apr 8, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

refactor: Remove OCMock Carthage dependency #1754

refactor: Remove OCMock Carthage dependency #1754

dplewis commented Oct 6, 2023 •

edited by mtrezza

Loading

parse-github-assistant bot commented Oct 6, 2023 •

edited

Loading

codecov bot commented Oct 6, 2023 •

edited

Loading

mtrezza commented Oct 6, 2023

dplewis commented Oct 6, 2023

mtrezza commented Oct 6, 2023

mtrezza left a comment

dplewis commented Oct 7, 2023

mtrezza left a comment •

edited

Loading

dplewis commented Oct 7, 2023 •

edited

Loading

mtrezza commented Oct 7, 2023

dplewis commented Oct 7, 2023 •

edited

Loading

dplewis commented Oct 7, 2023 •

edited

Loading

mtrezza commented Oct 7, 2023 •

edited

Loading

dplewis commented Oct 7, 2023 •

edited

Loading

mtrezza commented Oct 7, 2023

dplewis commented Oct 7, 2023 •

edited

Loading

mtrezza commented Oct 8, 2023

dplewis commented Oct 8, 2023 •

edited

Loading

mtrezza commented Oct 8, 2023

dplewis commented Oct 8, 2023

mtrezza commented Oct 8, 2023

parseplatformorg commented Apr 8, 2024

refactor: Remove OCMock Carthage dependency #1754

refactor: Remove OCMock Carthage dependency #1754

Conversation

dplewis commented Oct 6, 2023 • edited by mtrezza Loading

New Pull Request Checklist

Issue Description

Approach

TODOs before merging

parse-github-assistant bot commented Oct 6, 2023 • edited Loading

Thanks for opening this pull request!

codecov bot commented Oct 6, 2023 • edited Loading

Codecov Report

mtrezza commented Oct 6, 2023

dplewis commented Oct 6, 2023

mtrezza commented Oct 6, 2023

mtrezza left a comment

Choose a reason for hiding this comment

dplewis commented Oct 7, 2023

mtrezza left a comment • edited Loading

Choose a reason for hiding this comment

dplewis commented Oct 7, 2023 • edited Loading

mtrezza commented Oct 7, 2023

dplewis commented Oct 7, 2023 • edited Loading

dplewis commented Oct 7, 2023 • edited Loading

mtrezza commented Oct 7, 2023 • edited Loading

dplewis commented Oct 7, 2023 • edited Loading

mtrezza commented Oct 7, 2023

dplewis commented Oct 7, 2023 • edited Loading

mtrezza commented Oct 8, 2023

dplewis commented Oct 8, 2023 • edited Loading

mtrezza commented Oct 8, 2023

dplewis commented Oct 8, 2023

mtrezza commented Oct 8, 2023

parseplatformorg commented Apr 8, 2024

dplewis commented Oct 6, 2023 •

edited by mtrezza

Loading

parse-github-assistant bot commented Oct 6, 2023 •

edited

Loading

codecov bot commented Oct 6, 2023 •

edited

Loading

mtrezza left a comment •

edited

Loading

dplewis commented Oct 7, 2023 •

edited

Loading

dplewis commented Oct 7, 2023 •

edited

Loading

dplewis commented Oct 7, 2023 •

edited

Loading

mtrezza commented Oct 7, 2023 •

edited

Loading

dplewis commented Oct 7, 2023 •

edited

Loading

dplewis commented Oct 7, 2023 •

edited

Loading

dplewis commented Oct 8, 2023 •

edited

Loading